Skip to content

Clean Code for debug/org.eclipse.debug.ui.launchview.tests#2692

Open
eclipse-platform-bot wants to merge 1 commit into
masterfrom
clean-code/debug/org.eclipse.debug.ui.launchview.tests
Open

Clean Code for debug/org.eclipse.debug.ui.launchview.tests#2692
eclipse-platform-bot wants to merge 1 commit into
masterfrom
clean-code/debug/org.eclipse.debug.ui.launchview.tests

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Test Results

    54 files  ±0      54 suites  ±0   35m 36s ⏱️ -12s
 4 667 tests ±0   4 644 ✅  - 1   22 💤 ±0  1 ❌ +1 
11 895 runs  ±0  11 739 ✅  - 3  153 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit e469090. ± Comparison against base commit a569c2c.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/debug/org.eclipse.debug.ui.launchview.tests branch from 2027dce to e469090 Compare June 3, 2026 03:55
@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Jun 3, 2026

This seem to fail org.eclipse.debug.ui.launchview.tests.launchview.LaunchViewSmokeTest#testOpenView

org.opentest4j.AssertionFailedError: Failed to open launch configuration view
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
	at org.junit.jupiter.api.Assertions.fail(Assertions.java:138)
	at org.eclipse.debug.ui.launchview.tests.launchview.LaunchViewSmokeTest.testOpenView(LaunchViewSmokeTest.java:34)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

likely there is something contributed by one of the bundles that are not really used at compile time what would need an @Referenced or similar technique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants