Add characterization tests for terminal scrolling behavior#2701
Merged
vogella merged 1 commit intoJun 3, 2026
Merged
Conversation
Preparation work for eclipse-platform#2680 to ensure stability before changing how scroll regions interact with the scroll-back history. These lock the current behavior of VT100EmulatorBackend: - a newline in the full window grows the history (must be preserved), - a newline at the bottom of a scroll region with a non-top margin scrolls in place and discards the top line (must be preserved), - a reverse line feed at the top of a region scrolls down in place (must be preserved), - a newline at the bottom of a top-anchored region currently discards the top line; this documents the status quo that the planned fix will change so the line is added to the scroll-back instead. No production code changes.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation work for #2680 to ensure stability.
These add JUnit tests that lock the current scrolling behavior of the VT100 terminal emulator before any change is made to how scroll regions interact with the scroll-back history. Three of them are regression guards (full-window newline grows history, a scroll region with a non-top margin discards its top line in place, and a reverse line feed scrolls a region down in place) that must keep passing through the upcoming change. The fourth documents the current behavior of a top-anchored scroll region, which the planned fix for issue 2680 is expected to change so that the scrolled-off line is kept in the scroll-back instead of being discarded.
No production code is changed.