Check provided monitor before deleting files in background#2820
Open
iloveeclipse wants to merge 1 commit into
Open
Check provided monitor before deleting files in background#2820iloveeclipse wants to merge 1 commit into
iloveeclipse wants to merge 1 commit into
Conversation
iloveeclipse
commented
Jul 20, 2026
| futures.add(future); | ||
| }); | ||
| // Verify monitor can be used in other threads before deleting children in parallel | ||
| Future<?> threadCheck = executorService.submit(() -> infMonitor.subTask(Messages.checkingPreconditions)); |
Member
Author
There was a problem hiding this comment.
I'm not happy with that because if called recursively, we "probe" the monitor which we already identified as thread affine or not.
Also in most cases (no DND code path) we simply don't need this check at all.
Contributor
There was a problem hiding this comment.
InfiniteProgress Monitor is kinda useless anyway (gives no prediction), so you might just not report any progress as well.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2819