HTTP implementation based on Whiteboard Specification for Jakarta#396
Draft
kenwenzel wants to merge 1 commit into
Draft
HTTP implementation based on Whiteboard Specification for Jakarta#396kenwenzel wants to merge 1 commit into
kenwenzel wants to merge 1 commit into
Conversation
Author
|
@ifurnadjiev I've created the first changes for Jakarta Whiteboard. I could not test it as my target platform is not fully functional. Next steps are:
|
|
Can one of the admins verify this patch? |
Author
PR #396 Review: HTTP Implementation based on Whiteboard Specification for JakartaSummaryThis PR modernizes RAP's HTTP servlet registration by migrating from RAP's custom
Fixes: #394 ✓ Strengths
⚠ Concerns & Blockers1. Draft Status & CI/Test Results
2. Breaking API Change
3. HttpContext Removal May Impact Custom Implementations
4. Limited Documentation in Code
🔍 Code Quality Observations1. Boilerplate for Whiteboard PropertiesMultiple places repeat the 2. Silent Error Handlingcatch(IllegalStateException alreadyUnregistered) {
// Registrierung wurde bereits abgemeldet - ignorieren.
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses OSGi Whiteboard Specification for Jakarta instead of a modified HttpService for Jakarta.
This should allow to remove RAP's HTTP bundles and replace them with "standard" OSGi implementations.
Fixes #394