Add round-trip and leap-year coverage tests for DateTimeConverter (pre/post 1970) by Rutuja-Patil-Bosch · Pull Request #135 · eclipse-score/baselibs

Rutuja-Patil-Bosch · 2026-04-01T05:12:18Z

Summary

This PR extends unit test coverage for DateTimeConverter by adding round-trip validation and additional leap-year scenarios, especially around pre-1970 and post-1970 boundaries.

Changes

Added round-trip test validation:
- epoch → DateTime → epoch consistency checks
Added test coverage for:
- Pre-1970 leap year (1968)
- Post-1970 leap year (1972)
Included full month/day sweeps to validate:
- Leap day handling (Feb 29)
- Month boundary correctness
- Internal day-sum adjustments

Motivation

The added tests ensure correctness of:

Leap year handling logic
Edge cases around Unix epoch (1970)
Internal date-to-epoch conversion consistency

This improves confidence in DateTimeConverter for:

Historical timestamps (pre-1970)
Leap year transitions
Boundary conditions in conversion logic

Notes

Invalid dates are skipped during iteration
Focus is on ensuring no regression in conversion logic
No production code changes included

Test Scope

Covers both:
- 'dateTimeToEpoch'
- 'epochToDateTime'
Validates bidirectional consistency

Impact

Increased unit test coverage
Better validation of edge cases and leap-year logic
No impact on runtime behavior

…lse_isValidDateTimeFormat EpochToDateTime_Before1970_LeapYear_January_AdjustsDaysSum invalid_day_values invalid_month_values

removed redundnat checks

Feature: bgsw_baselib_ut

github-actions · 2026-04-01T05:19:16Z

The created documentation from the pull request is available at: docu-html

AlexanderLanin · 2026-04-08T07:48:57Z

@Rutuja-Patil-Bosch please avoid bot based commits. Feel free to contact me directly.

Review findings are fixed for eclipse-score#135 Changes are: 1. Test cases are spitted to get more clarity with asserts 2. Instead of loop added hardcoded values to avoid dead/unreachable code 3. RecordProperty are updated with only spec listed variables

4og · 2026-05-15T09:34:04Z

@gierer, please have a look at this PR

gierer · 2026-05-18T13:19:56Z

+        return;
+    auto dateTimeConverted = score::common::epochToDateTime(epoch);
+    ASSERT_NE(dateTimeConverted, nullptr);
+    ASSERT_EQ(dateTimeConverted->m_year, 1968);     


Please check all values. Something like "ASSERT_EQ(dateTimeConverted, dateTimeOriginal );

@gierer For this, std::make_shared(1968, 12, 31, 0, 0, 1);
then for day check this will be ASSERT_EQ(dateTimeConverted->m_day, 30);

Reason: Expected by current algorithm: pre-1970 leap-year path decrements daysSum once.

I'll add for checks for all values

gierer · 2026-05-18T13:21:12Z

+    auto dateTimeConverted = score::common::epochToDateTime(epoch);
+    ASSERT_NE(dateTimeConverted, nullptr);
+	//After  1970 year is adjusted based on daysome
+    ASSERT_EQ(dateTimeConverted->m_year, 1973); 


Why is this no longer 1972?

@gierer This verifies existing implementation behavior (not roundtrip preservation : the value may change after converting to epoch and back and this test accepts/document that current behavior.).
For input 1972-12-31 00:00:01, epochToDateTime() currently returns year 1973.

The conversion should be either correct or return an error.
A test is meant to verify correct behaviour of the code. So if the code has a bug it needs to be fixed, instead of breaking the test as well. Code coverage gained through incorrect assertions has zero value — it doesn't verify correctness and creates a false sense of quality.

@gierer : Should I update code in the same PR? or different PR is required ?

gierer · 2026-05-18T13:22:37Z

+    RecordProperty("TestType", "requirements-based");
+
+    time_t epoch{};
+    auto d = std::make_shared<DateTimeType>(1968, 1, 1, 0, 0, 1);


Please use proper variable names.

gierer · 2026-05-18T13:25:37Z

+    ASSERT_TRUE(score::common::dateTimeToEpoch(d, &epoch));
+
+    auto dt = score::common::epochToDateTime(epoch);
+	//InvalidDateTimeFormat due to day some adjustment & returns nullptr


Why is this no longer valid? Is this a bug in the implementation?

@gierer This may indicate a converter defect.
This test documents current implementation behavior (known pre-1970 leap-year boundary issue), not roundtrip correctness.
For 1968-01-01 00:00:01, epochToDateTime() currently returns nullptr after daysSum adjustments in the pre-1970 leap-year path.

gierer · 2026-05-18T13:28:08Z

+    if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
+        return;


Suggested change

if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))

return;

ASSERT_TRUE(score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))

Copilot

Pull request overview

This PR adds additional unit tests for score::common::DateTimeConverter to increase coverage around invalid date inputs and leap-year / pre-/post-1970 conversion edge cases.

Changes:

Added tests for invalid month/day values in isValidDateTimeFormat.
Added a test ensuring dateTimeToEpoch returns false and does not mutate the output epoch when the input is invalid.
Added a few DateTime→epoch→DateTime “round-trip” tests targeting 1968 and 1972 leap-year boundaries.

Comments suppressed due to low confidence (3)

score/datetime_converter/datetime_converter_test.cpp:526

Same issue here: the test returns early if dateTimeToEpoch fails, which makes the test pass without validating anything. Use an assertion so failures are visible and the remainder of the test always executes when appropriate.

    time_t epoch{};
    auto dateTimeOriginal =
        std::make_shared<DateTimeType>(1972, 12, 31, 0, 0, 1);
		
    if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
        return;
		
    auto dateTimeConverted = score::common::epochToDateTime(epoch);

score/datetime_converter/datetime_converter_test.cpp:530

The assertion expects the year to change from 1972 to 1973 after a DateTime→epoch→DateTime round-trip, which contradicts the test description (“remain unchanged”) and will lock in incorrect behavior. The round-trip expectation should match the original datetime fields.

    auto dateTimeConverted = score::common::epochToDateTime(epoch);
    ASSERT_NE(dateTimeConverted, nullptr);
	//After  1970 year is adjusted based on daysome
    ASSERT_EQ(dateTimeConverted->m_year, 1973);

score/datetime_converter/datetime_converter_test.cpp:546

This test expects epochToDateTime to return nullptr for a valid date (1968-01-01) even though dateTimeToEpoch succeeded, which would encode a conversion bug rather than catch it. If this is intended behavior, it should be documented at the API level; otherwise the test should assert that the round-trip returns a valid DateTime equal to the input.

    RecordProperty("Description",
        "Verify that conversion from DateTime to Epoch to DateTime for pre-1970 leap year boundary (1968-01-01) results in an invalid DateTime, returning nullptr due to daysSum adjustment.");
    RecordProperty("TestType", "requirements-based");
	
    time_t epoch{};
    auto d = std::make_shared<DateTimeType>(1968, 1, 1, 0, 0, 1);
    ASSERT_TRUE(score::common::dateTimeToEpoch(d, &epoch));
	
    auto dt = score::common::epochToDateTime(epoch);
	//InvalidDateTimeFormat due to day some adjustment & returns nullptr
    EXPECT_EQ(dt, nullptr);
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    time_t epoch{};
+    auto dateTimeOriginal =
+        std::make_shared<DateTimeType>(1968, 12, 31, 0, 0, 1);
+    if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
+        return;
+    auto dateTimeConverted = score::common::epochToDateTime(epoch);


+    auto dateTimeOriginal =
+        std::make_shared<DateTimeType>(1968, 12, 31, 0, 0, 1);
+    if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
+        return;
+    auto dateTimeConverted = score::common::epochToDateTime(epoch);
+    ASSERT_NE(dateTimeConverted, nullptr);
+    ASSERT_EQ(dateTimeConverted->m_year, 1968);     
+}


+	//After  1970 year is adjusted based on daysome
+    ASSERT_EQ(dateTimeConverted->m_year, 1973); 
+
+}
+
+TEST_F(DateTimeConverterTest, EpochToDateTime_Pre1970_LeapYear_Jan1_InvalidConversion_ReturnsNull)
+{
+    RecordProperty("Description",
+        "Verify that conversion from DateTime to Epoch to DateTime for pre-1970 leap year boundary (1968-01-01) results in an invalid DateTime, returning nullptr due to daysSum adjustment.");
+    RecordProperty("TestType", "requirements-based");
+
+    time_t epoch{};
+    auto d = std::make_shared<DateTimeType>(1968, 1, 1, 0, 0, 1);
+    ASSERT_TRUE(score::common::dateTimeToEpoch(d, &epoch));
+
+    auto dt = score::common::epochToDateTime(epoch);
+	//InvalidDateTimeFormat due to day some adjustment & returns nullptr
+    EXPECT_EQ(dt, nullptr);


+
+    if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
+        return;
+
+    auto dateTimeConverted = score::common::epochToDateTime(epoch);
+    ASSERT_NE(dateTimeConverted, nullptr);
+	//After  1970 year is adjusted based on daysome
+    ASSERT_EQ(dateTimeConverted->m_year, 1973); 
+


+TEST_F(DateTimeConverterTest, EpochToDateTime_Pre1970_LeapYear_DaysSumDecrementedInJanuary)
+{
+    RecordProperty("Description", "Verify that datetime values remain unchanged after roundtrip conversion (DateTime to Epoch to DateTime) for pre 1970 leap years.");
+    RecordProperty("TestType", "requirements-based");
+
+    time_t epoch{};
+    auto dateTimeOriginal =
+        std::make_shared<DateTimeType>(1968, 12, 31, 0, 0, 1);
+    if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
+        return;
+    auto dateTimeConverted = score::common::epochToDateTime(epoch);
+    ASSERT_NE(dateTimeConverted, nullptr);
+    ASSERT_EQ(dateTimeConverted->m_year, 1968);     
+}
+
+TEST_F(DateTimeConverterTest, EpochToDateTime_Post1970_LeapYear_DaysSumDecremented)
+{
+    RecordProperty("Description",
+        "Verify that datetime values remain unchanged after roundtrip conversion (DateTime to Epoch to DateTime) for post-1970 leap years.");
+    RecordProperty("TestType", "requirements-based");
+
+    time_t epoch{};
+    auto dateTimeOriginal =
+        std::make_shared<DateTimeType>(1972, 12, 31, 0, 0, 1);
+
+    if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
+        return;
+
+    auto dateTimeConverted = score::common::epochToDateTime(epoch);
+    ASSERT_NE(dateTimeConverted, nullptr);
+	//After  1970 year is adjusted based on daysome
+    ASSERT_EQ(dateTimeConverted->m_year, 1973); 
+
+}
+
+TEST_F(DateTimeConverterTest, EpochToDateTime_Pre1970_LeapYear_Jan1_InvalidConversion_ReturnsNull)
+{
+    RecordProperty("Description",


+TEST_F(DateTimeConverterTest, EpochToDateTime_Pre1970_LeapYear_DaysSumDecrementedInJanuary)
+{
+    RecordProperty("Description", "Verify that datetime values remain unchanged after roundtrip conversion (DateTime to Epoch to DateTime) for pre 1970 leap years.");
+    RecordProperty("TestType", "requirements-based");
+


Rutuja-Patil-Bosch and others added 3 commits March 24, 2026 14:04

Added UT test cases for baselib datetime_converter dateTimeToEpoch_fa…

e4b86dc

…lse_isValidDateTimeFormat EpochToDateTime_Before1970_LeapYear_January_AdjustsDaysSum invalid_day_values invalid_month_values

Updated the review findings: Removed cout statements

d6572d9

removed redundnat checks

Merge pull request #1 from bgsw-contrib/bgsw_baselib_ut

253624a

Feature: bgsw_baselib_ut

Rutuja-Patil-Bosch requested review from 4og, LittleHuba, castler, hoe-jo, nradakovic and ramceb as code owners April 1, 2026 05:12

github-project-automation Bot added this to BAS - Baselibs FT Apr 1, 2026

github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Apr 1, 2026

Rutuja-Patil-Bosch temporarily deployed to workflow-approval April 1, 2026 05:12 — with GitHub Actions Inactive

gierer suggested changes Apr 7, 2026

View reviewed changes

Merge branch 'eclipse-score:main' into main

3d6f2a0

bgsw-contrib Bot had a problem deploying to workflow-approval April 8, 2026 00:23 Failure

Merge branch 'eclipse-score:main' into main

fc37837

bgsw-contrib Bot had a problem deploying to workflow-approval April 9, 2026 00:19 Failure

UT Review finding fix for eclipse-score#135

b89ff46

4og mentioned this pull request Apr 9, 2026

Bgsw baselib ut #137

Open

Merge branch 'eclipse-score:main' into main

fa194a0

bgsw-contrib Bot temporarily deployed to workflow-approval April 10, 2026 00:22 Inactive

Merge branch 'eclipse-score:main' into main

b48fc3c

bgsw-contrib Bot had a problem deploying to workflow-approval April 11, 2026 00:21 Failure

bgsw-contrib Bot requested a deployment to workflow-approval May 9, 2026 00:33 Waiting

Rutuja-Patil-Bosch requested a deployment to workflow-approval May 11, 2026 11:34 — with GitHub Actions Waiting

Merge branch 'eclipse-score:main' into main

b5a9f90

bgsw-contrib Bot temporarily deployed to workflow-approval May 12, 2026 00:32 Inactive

Merge branch 'eclipse-score:main' into main

7751a52

bgsw-contrib Bot temporarily deployed to workflow-approval May 14, 2026 00:36 Inactive

4og added the comp-datetime Related to score/datetime_converter component label May 15, 2026

Merge branch 'eclipse-score:main' into main

1e8c7ba

bgsw-contrib Bot requested a deployment to workflow-approval May 16, 2026 00:32 Waiting

gierer suggested changes May 18, 2026

View reviewed changes

Merge branch 'eclipse-score:main' into main

daf8a5f

bgsw-contrib Bot deployed to workflow-approval May 22, 2026 00:37 Active

bgsw-contrib Bot temporarily deployed to workflow-approval May 22, 2026 00:37 Inactive

4og requested review from Copilot and removed request for LittleHuba, castler, hoe-jo, nradakovic and ramceb May 22, 2026 20:31

Copilot started reviewing on behalf of 4og May 22, 2026 20:32 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Merge branch 'eclipse-score:main' into main

d01dbaa

bgsw-contrib Bot requested a deployment to workflow-approval May 23, 2026 00:36 Waiting

		if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
		return;

	if (!score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))
	return;
	ASSERT_TRUE(score::common::dateTimeToEpoch(dateTimeOriginal, &epoch))

Conversation

Rutuja-Patil-Bosch commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Motivation

Notes

Test Scope

Impact

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexanderLanin commented Apr 8, 2026

Uh oh!

4og commented May 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Rutuja-Patil-Bosch commented Apr 1, 2026 •

edited

Loading