Skip to content

perf: Split metamodel test#568

Merged
MaximilianSoerenPollak merged 4 commits into
eclipse-score:mainfrom
etas-contrib:split-metamodel-test
Jun 1, 2026
Merged

perf: Split metamodel test#568
MaximilianSoerenPollak merged 4 commits into
eclipse-score:mainfrom
etas-contrib:split-metamodel-test

Conversation

@a-zw
Copy link
Copy Markdown
Contributor

@a-zw a-zw commented May 29, 2026

Splitting up the slowest test for better caching. Also, removing needs.json downloads.

📌 Description

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: d312a289-d775-44e8-a1a1-d5113e0058c9
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 5.930s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

a-zw added 2 commits May 29, 2026 15:55
This costs ~700ms x 15+ tests.
Also, network access is not a good thing for tests.
@a-zw a-zw force-pushed the split-metamodel-test branch from 63155f2 to 312283f Compare May 29, 2026 13:55
@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment thread src/extensions/score_metamodel/tests/test_rules_file_based.py Outdated
Comment thread src/extensions/score_metamodel/BUILD Outdated
Comment thread src/extensions/score_metamodel/BUILD
Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 comments.
The size thing is irrelevant for this PR and something we need to address overall

@a-zw a-zw force-pushed the split-metamodel-test branch from 3c015f3 to a862bea Compare May 29, 2026 14:44
It is ok to rely on needs.json in all the tests.
The point was to to avoid downloading it.
Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this should speed things up and give more clarity 💯

@MaximilianSoerenPollak MaximilianSoerenPollak merged commit def73b8 into eclipse-score:main Jun 1, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants