Skip to content

Contribution proposal by ETAS#1

Merged
masc2023 merged 7 commits into
eclipse-score:mainfrom
etas-contrib:etas_crypto_pitch
May 22, 2026
Merged

Contribution proposal by ETAS#1
masc2023 merged 7 commits into
eclipse-score:mainfrom
etas-contrib:etas_crypto_pitch

Conversation

@ChansAlive
Copy link
Copy Markdown
Contributor

@ChansAlive ChansAlive commented Apr 24, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 00755f1c-a031-4d52-a2f8-235aee7c470d
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'abseil-cpp+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-m3oGQwXp/ZTRJP+mzDWFkutCtdpYj7TgfQklSqQAhts="
DEBUG: Repository abseil-cpp+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
DEBUG: Rule 'protobuf+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-w6Cp7OiTLjHDtzbi2xixxC5wcM2biBOIsm0BqnHiTKI="
DEBUG: Repository protobuf+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'grpc+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-CvN7gAlTEwtHwHW1ZoPuYL3D7aPDf8YAQZP1tWl1ggQ="
DEBUG: Repository grpc+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_bazel_platforms', the root module requires module version score_bazel_platforms@0.1.1, but got score_bazel_platforms@0.1.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.2.16, but got rules_cc@0.2.17 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'flatbuffers', the root module requires module version flatbuffers@25.2.10, but got flatbuffers@25.12.19 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
INFO: Elapsed time: 14.555s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

The created documentation from the pull request is available at: docu-html

@qor-lb qor-lb mentioned this pull request Apr 27, 2026
Closed
@qor-lb qor-lb linked an issue Apr 27, 2026 that may be closed by this pull request
[Contribution Proposal] Security ETAS eclipse-score/score#2220
Closed
@sunildevda sunildevda mentioned this pull request May 19, 2026
Open
@ChansAlive ChansAlive force-pushed the etas_crypto_pitch branch from aa1ff06 to c9659cf Compare May 22, 2026 08:35
ChansAlive and others added 7 commits May 22, 2026 17:19
@ChansAlive
Initial pitch commit by ETAS
f08af82 
More details can be found in the ptich presentation #2220

Also-by: athul.mallappallil@etas.com, oliver.heilwagen@etas.com, sebastian.lobsinger@etas.com, guruprasad.bhat@etas.com, sunilkumar.prasanchand@etas.com, tibor.zavartkay@etas.com
@OliverHeilwagen @ChansAlive
Update devcontainer. Add pre-commit config.
4e6dec2 
* Update devcontainer.
* Add pre-commit config.
  - disabled copyright check (for now)
  - format-fix
  - generate-compile-commands
  - clang-format
  - clang-tidy
* Add clang-format file
* Add clang-tidy file
* Update README to avoid common devcontainer pitfalls.
@GuruprasadBhatL @ChansAlive
Use mw::log to replace std::cerr / cout
a349194 
-  std::cerr under the folder score replaced with score::mw::log::LogError()
-  std::cout is replaced with score::mw::log::LogDebug(), those with ERROR in their body are replaced with  score::mw::log::LogError()
-  std::cout/cerr under tests remain untouched
@ChansAlive
Unify the stream calls, Change stream validation
49be10c 
- Unify various streaming API calls
- Update stream validation logic to use enums instead of string
@ChansAlive
Fix documentation and util function signature
c8a1d56 
- Fix documentation issues
- Update the function signature for functions in handler utils
@se-lo @ChansAlive
Update copyrights
39faa28
@se-lo @ChansAlive
Added files from module template
4ca115f 
* Add missing files from module template
* Ignore template sync for .pre-commit-config.yaml, until harmonized
* Bring in bazel lock file for workflow checks
* Remove obsolete comment from pre-commit-config

Also-by: OliverHeilwagen <Oliver.Heilwagen@etas.com>
@ChansAlive ChansAlive force-pushed the etas_crypto_pitch branch from c75bf8c to 4ca115f Compare May 22, 2026 15:43
@OliverHeilwagen OliverHeilwagen requested a review from masc2023 May 22, 2026 15:46
Copilot AI reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

masc2023
masc2023 approved these changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial contribution, all checks passed, further iteration to fulfill S-CORE requirements to be part of reference integration required

@masc2023 masc2023 merged commit c3e4df4 into eclipse-score:main May 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@masc2023 masc2023 masc2023 approved these changes

@eclipse-score-bot eclipse-score-bot Awaiting requested review from eclipse-score-bot

Assignees

@ChansAlive ChansAlive

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Contribution Proposal] Security ETAS

6 participants

@ChansAlive @masc2023 @OliverHeilwagen @GuruprasadBhatL @se-lo