Skip to content

Reorganize folder structure#211

Draft
MaciejKaszynski wants to merge 7 commits into
eclipse-score:mainfrom
etas-contrib:reorganize-folder-structure
Draft

Reorganize folder structure#211
MaciejKaszynski wants to merge 7 commits into
eclipse-score:mainfrom
etas-contrib:reorganize-folder-structure

Conversation

@MaciejKaszynski
Copy link
Copy Markdown
Contributor

@MaciejKaszynski MaciejKaszynski commented May 22, 2026

Reorganize folder structure to follow other score modules and the description in #210

Resolves:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 317a17e2-d9f0-4156-a3e9-fe5dfa75c72c
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (29 packages loaded, 10 targets configured)

Analyzing: target //:license-check (83 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (137 packages loaded, 2708 targets configured)

Analyzing: target //:license-check (146 packages loaded, 5113 targets configured)

Analyzing: target //:license-check (147 packages loaded, 8036 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8094 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8218 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 10232 targets configured).
[9 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 23.262s, Critical Path: 2.36s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@@ -71,7 +71,7 @@ cc_library_with_common_opts(
],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this directly to alive_monitor?
To continue the renaming from #206

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure under health_monitoring_lib/cpp/ seems different to the rest of the cpp code (include folder, cpp files on top level instead of the public headers, etc).
Should this stay as-is or follow the same sturcture as in the other cpp folders?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose we move concurrency as a subfolder under common.
Does not really look like a top-level subcomponent to me.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The health_monitor_lib/include/score/lcm will be public API of launch_manager.
Should we move this already to score/mw/lifecycle/alive_monitor?

We can then as follow up rename the API (see #149)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move everything under health_monitor_lib/src/score/lcm/saf to be in score/mw/launch_manager_daemon/alive_monitor?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current lifecycleClient will be a public API that needs to be refactored to be a single method report_running().

Can we already move this under score/mw/lifecycle/lifecycle_client?

Comment thread score/mw/common/BUILD
cc_library(
name = "constants",
hdrs = ["constants.hpp"],
include_prefix = "score/lcm/internal",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need these different include prefixes? Can we not update the include paths?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename to "Control".

Communication might be misleading as there is other communication going on that is not part of this folder (e.g. reporting Running state, alive notifications)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should create a folder "configuration" and move the current config and configuration_manager folder into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants