Reorganize folder structure#211
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
| @@ -71,7 +71,7 @@ cc_library_with_common_opts( | |||
| ], | |||
There was a problem hiding this comment.
Should we rename this directly to alive_monitor?
To continue the renaming from #206
There was a problem hiding this comment.
The structure under health_monitoring_lib/cpp/ seems different to the rest of the cpp code (include folder, cpp files on top level instead of the public headers, etc).
Should this stay as-is or follow the same sturcture as in the other cpp folders?
There was a problem hiding this comment.
I would propose we move concurrency as a subfolder under common.
Does not really look like a top-level subcomponent to me.
There was a problem hiding this comment.
The health_monitor_lib/include/score/lcm will be public API of launch_manager.
Should we move this already to score/mw/lifecycle/alive_monitor?
We can then as follow up rename the API (see #149)
There was a problem hiding this comment.
Can we move everything under health_monitor_lib/src/score/lcm/saf to be in score/mw/launch_manager_daemon/alive_monitor?
There was a problem hiding this comment.
The current lifecycleClient will be a public API that needs to be refactored to be a single method report_running().
Can we already move this under score/mw/lifecycle/lifecycle_client?
| cc_library( | ||
| name = "constants", | ||
| hdrs = ["constants.hpp"], | ||
| include_prefix = "score/lcm/internal", |
There was a problem hiding this comment.
why do we need these different include prefixes? Can we not update the include paths?
9f6965d to
6fee38e
Compare
There was a problem hiding this comment.
Could we rename to "Control".
Communication might be misleading as there is other communication going on that is not part of this folder (e.g. reporting Running state, alive notifications)
There was a problem hiding this comment.
I wonder if we should create a folder "configuration" and move the current config and configuration_manager folder into that
Reorganize folder structure to follow other score modules and the description in #210
Resolves: