Skip to content

fix: allow clicking into hover tooltips to select and copy content#17161

Merged
ndoschek merged 1 commit intomasterfrom
GH-15986
Mar 17, 2026
Merged

fix: allow clicking into hover tooltips to select and copy content#17161
ndoschek merged 1 commit intomasterfrom
GH-15986

Conversation

@ndoschek
Copy link
Copy Markdown
Member

What it does

Resolves GH-15986

  • Check if mousedown target is inside the hover host before canceling, so clicks within the tooltip no longer dismiss it
  • Add user-select: text to the hover CSS to ensure text is selectable

How to test

  1. Hover over an element that shows a static tooltip (e.g. title of any sidebar view like Explorer)
  2. Click and drag or doubleclick to select text inside the tooltip, verify text selection works and content can be copied
  3. Click outside the tooltip and verify it dismisses as expected
  4. Hover over an element that shows an interactive tooltip (e.g. the language status bar item { })
  5. Click an action in the hover tooltip, verify it stays open and does not dismiss

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Resolves GH-15986

- Check if mousedown target is inside the hover host before canceling,
  so clicks within the tooltip no longer dismiss it
- Add user-select: text to the hover CSS to ensure text is selectable
Copy link
Copy Markdown
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM 👍

@github-project-automation github-project-automation Bot moved this from Waiting on reviewers to Needs merge in PR Backlog Mar 17, 2026
@ndoschek ndoschek merged commit 8b83716 into master Mar 17, 2026
10 checks passed
@ndoschek ndoschek deleted the GH-15986 branch March 17, 2026 13:28
@github-project-automation github-project-automation Bot moved this from Needs merge to Done in PR Backlog Mar 17, 2026
@github-actions github-actions Bot added this to the 1.70.0 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Tooltip content can no longer be focused

2 participants