Fix initialization and re-computation of expirationTimestamp in Http2ClientConnectionImpl#5866
Open
ahus1 wants to merge 1 commit into
Open
Fix initialization and re-computation of expirationTimestamp in Http2ClientConnectionImpl#5866ahus1 wants to merge 1 commit into
ahus1 wants to merge 1 commit into
Conversation
…ClientConnectionImpl Closes eclipse-vertx#5865
ahus1
force-pushed
the
is-5865-connection-impl-keepalive
branch
from
e0df732 to
1eb0c76
Compare
Member
|
@ahus1 is that possible to have a test for this ? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5865
Motivation:
Setting
expirationTimestampis required before the connection is recycled to ensure that the background timer executed correctly.In a previous attempt I tried to set the initial value to
Long.MAX_VALUE, but thenHttp2Test.testClientKeepAliveTimeoutNoStreamsstarted failing. So I'm no setting it a value usingrecycle().