Configurable chunk size for chunked send file#6159
Open
doxlik wants to merge 1 commit into
Open
Conversation
Signed-off-by: doxlik <doxlikx@gmail.com>
doxlik
force-pushed
the
configurable-send-file-chunk-size
branch
from
018f879 to
220a748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently for non-sendfile (non zero copy) send files the chunk size is hardcoded to 8kb which is good default but not always best size, as example in my benchmarks 32 kb showed much better throughput.
Closes #6160