Allow zero HTTP/2 keep-alive timeout#6214
Open
shblue21 wants to merge 1 commit into
Open
Conversation
Motivation: Http2ClientConfig#setKeepAliveTimeout(Duration.ZERO) throws, although zero and null are documented as no timeout. HTTP/1 and HTTP/3 client configs already accept zero. Changes: Allow zero for HTTP/2 keep-alive timeout and add a regression test. Signed-off-by: Jihun Kim <shblue21@naver.com>
shblue21
force-pushed
the
fix/http2-keep-alive-zero
branch
from
b2994ca to
b32887d
Compare
Contributor
Author
|
This looks related to the recent HTTP client config changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Http2ClientConfig#setKeepAliveTimeout(Duration.ZERO)currently throws.The method documents zero and
nullas no timeout, and HTTP/1 and HTTP/3client configs already accept zero.
This change allows zero for HTTP/2 keep-alive timeout while still rejecting
negative durations, and adds a regression test.
Conformance:
I have signed the ECA.