Clarify SocketConnectionBase exception handling flow report.#1677
Merged
Conversation
Motivation: SocketConnectionBase handleException method should only be called by the underlying socket exception handler, when it happens the close handler will be called subsequently by the socket. Changes: Instead of calling the internal handleClose from the handleException method, we should capture the exception reported and reuse it when handleClosed is called. Remove the handleException call from the try/catch block in handleMessage, handleMessage should never throw an exception, if it does, it will be logged by the socket calling handleMessage (that would be a bug). Remove the PgSocketConnection handleException override that reports the exception, since now the base method will capture the exception, the handleClose will call reportException instead. Remove unused DB2SocketConnection code that was doing nothing. Make a few methods private to SocketConnectionBase to ensure they are only called in an expected way.
vietj
force-pushed
the
socket-connection-base-exception-handling
branch
from
fc4a61a to
e2b708e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
SocketConnectionBasehandleExceptionmethod should only be called by the underlying socket exception handler, when it happens the close handler will be called subsequently by the socket.Changes:
Instead of calling the internal
handleClosefrom thehandleExceptionmethod, we should capture the exception reported and reuse it whenhandleClosedis called.Remove the
handleExceptioncall from the try/catch block inhandleMessage,handleMessageshould never throw an exception, if it does, it will be logged by the socket callinghandleMessage(that would be a bug).Remove the
PgSocketConnectionhandleExceptionoverride that reports the exception, since now the base method will capture the exception, thehandleClosewill callreportExceptioninstead.Remove unused
DB2SocketConnectioncode that was doing nothing.Make a few methods private to
SocketConnectionBaseto ensure they are only called in an expected way.