Skip to content

METK-163: Tile key support#198

Merged
danovaro merged 6 commits into
ecmwf:developfrom
mjg41:feature/METK-163-tile-key-support
Apr 23, 2026
Merged

METK-163: Tile key support#198
danovaro merged 6 commits into
ecmwf:developfrom
mjg41:feature/METK-163-tile-key-support

Conversation

@mjg41
Copy link
Copy Markdown
Contributor

@mjg41 mjg41 commented Apr 13, 2026

Description

Following the approval of the addition of the tile, tileattribute and tilescheme keys in codex MARS - 006:
MARS-006-Land-Surface-Tile-Data.md

Comments and modifications very much welcome before merge!

FYI @danovaro , @simondsmart

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@danovaro danovaro added the approved-for-ci Approved for CI run label Apr 22, 2026
Copy link
Copy Markdown
Member

@danovaro danovaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes requested, which block language parsing

Comment thread share/metkit/language.yaml Outdated
Comment thread share/metkit/language.yaml Outdated
Comment thread share/metkit/language.yaml Outdated
Comment thread share/metkit/language.yaml Outdated
Comment thread share/metkit/language.yaml Outdated
@github-actions github-actions Bot removed the approved-for-ci Approved for CI run label Apr 22, 2026
@mjg41
Copy link
Copy Markdown
Contributor Author

mjg41 commented Apr 22, 2026

Thank you very much @danovaro for the review! With the latest commit I should have resolved your comments.

@danovaro danovaro added the approved-for-ci Approved for CI run label Apr 22, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.71%. Comparing base (6b8bf0a) to head (1af78cf).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #198   +/-   ##
========================================
  Coverage    61.71%   61.71%           
========================================
  Files          303      303           
  Lines        11789    11789           
  Branches      1049     1049           
========================================
  Hits          7276     7276           
  Misses        4513     4513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danovaro danovaro merged commit 2de8ed6 into ecmwf:develop Apr 23, 2026
187 of 196 checks passed
@mjg41 mjg41 deleted the feature/METK-163-tile-key-support branch April 23, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants