Fix Healpix encoding#199
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #199 +/- ##
===========================================
- Coverage 62.03% 62.02% -0.01%
===========================================
Files 303 303
Lines 11671 11672 +1
Branches 1049 1049
===========================================
Hits 7240 7240
- Misses 4431 4432 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tweska
approved these changes
Apr 17, 2026
Member
tweska
left a comment
There was a problem hiding this comment.
Looks good to me. I ran clang-format to make the CI happy.
pgeier
approved these changes
Apr 17, 2026
Contributor
pgeier
left a comment
There was a problem hiding this comment.
climate dts HEALPix output get encoded correctly with this change
MircoValentiniECMWF
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Healpix case in RepresentationMatcher was missing, and in the representationEncoding Nside key is with Capital letter and orderingConvention expects a string. If you prefer we can use ordering, and keep the previous logic, which would work with the numerical value.
Contributor Declaration
By opening this pull request, I affirm the following: