Skip to content

Fix Healpix encoding#199

Merged
dsarmany merged 3 commits into
developfrom
fix/healpix
Apr 29, 2026
Merged

Fix Healpix encoding#199
dsarmany merged 3 commits into
developfrom
fix/healpix

Conversation

@stefaniereuter
Copy link
Copy Markdown
Contributor

Description

Healpix case in RepresentationMatcher was missing, and in the representationEncoding Nside key is with Capital letter and orderingConvention expects a string. If you prefer we can use ordering, and keep the previous logic, which would work with the numerical value.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.02%. Comparing base (0e5d0f6) to head (2047694).

Files with missing lines Patch % Lines
...d/concepts/representation/representationEncoding.h 0.00% 3 Missing ⚠️
...nd/concepts/representation/representationMatcher.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #199      +/-   ##
===========================================
- Coverage    62.03%   62.02%   -0.01%     
===========================================
  Files          303      303              
  Lines        11671    11672       +1     
  Branches      1049     1049              
===========================================
  Hits          7240     7240              
- Misses        4431     4432       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@tweska tweska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I ran clang-format to make the CI happy.

Copy link
Copy Markdown
Contributor

@pgeier pgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

climate dts HEALPix output get encoded correctly with this change

@dsarmany dsarmany merged commit cbfcd75 into develop Apr 29, 2026
185 of 192 checks passed
@dsarmany dsarmany deleted the fix/healpix branch April 29, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants