add print to Matcher#208
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #208 +/- ##
===========================================
+ Coverage 73.36% 73.42% +0.05%
===========================================
Files 126 126
Lines 8137 8154 +17
Branches 778 779 +1
===========================================
+ Hits 5970 5987 +17
Misses 2167 2167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds stream-printing support to metkit::mars::Matcher to make match conditions easier to inspect/debug via std::ostream output.
Changes:
- Adds
Matcher::print(std::ostream&) constand an inlineoperator<<overload inMatcher.h. - Implements
Matcher::print()inMatcher.ccto format the internalregexMap_as{key=regex,...}.
mars2grib documentation synchronization (Guideline 1000000):
- Impacted files under
src/metkit/mars2grib/**: none - Documentation status: ✅ in sync (no mars2grib-facing changes)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/metkit/mars/Matcher.h | Adds print() declaration and operator<< overload for Matcher. |
| src/metkit/mars/Matcher.cc | Implements Matcher::print() to stream the matcher’s key/regex map. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: