fix: mars2grib guard HAVE_ECKIT_GEO#210
Merged
Merged
Conversation
tweska
requested changes
May 8, 2026
Member
There was a problem hiding this comment.
eckit::geo is not an optional dependency for the mars2grib encoder. Correct me if I am wrong, but I think this change makes it "optional" and then it will just crash the build.
I think instead we must set the condition HAVE_ECKIT_GEO here:
Lines 65 to 68 in cbfcd75
Contributor
|
I fully agree with Kevin |
0b14ad2 to
7ff20fe
Compare
Member
|
Thanks for the fix @mcakircali! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #210 +/- ##
============================================
+ Coverage 62.02% 73.36% +11.33%
============================================
Files 303 126 -177
Lines 11672 8137 -3535
Branches 1049 778 -271
============================================
- Hits 7240 5970 -1270
+ Misses 4432 2167 -2265 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mars2grib_libs must be guarded with HAVE_ECKIT_GEO
Contributor Declaration
By opening this pull request, I affirm the following: