Fix conditions for feature MARS2GRIB#212
Merged
Merged
Conversation
tweska
requested review from
MircoValentiniECMWF,
danovaro,
dsarmany,
marcosbento and
mcakircali
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #212 +/- ##
========================================
Coverage 62.08% 62.08%
========================================
Files 303 303
Lines 11689 11689
Branches 1050 1050
========================================
Hits 7257 7257
Misses 4432 4432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcakircali
reviewed
May 13, 2026
Member
Author
|
Updated the PR so that we just add the additional condition |
Member
Author
|
This PR goes together with this PR in Multio: ecmwf/multio#276 |
dsarmany
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit sets eccodes and eckit as required packages for the feature
MARS2GRIBthen checks if targeteckit_geois present. If it is not present, there is an error.The second commit sets the target
eckit_geoas a condition for the featureMARS2GRIBinstead.If we want the solution of the second commit, we should squash the commits and keep the last message.