Deprecate NonCopyable in favour of explicitly deleted ctors#48
Merged
Conversation
94efb78 to
4eff669
Compare
4eff669 to
cfba30a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #48 +/- ##
===========================================
- Coverage 86.94% 86.91% -0.03%
===========================================
Files 188 188
Lines 15116 15021 -95
Branches 1363 1363
===========================================
- Hits 13142 13055 -87
+ Misses 1974 1966 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simondsmart
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An attempt to modernize the code base, by deprecating the "old style" NonCopyable in favour of explicitly deleting copy ctor/copy assignment operator.
This follows the advice of the CppCoreGuidelines, which states = delete is preferred -- see the discussion isocpp/CppCoreGuidelines#1354 (comment).
The proposed effectively remove a "small" eckit dependency
Contributor Declaration
By opening this pull request, I affirm the following:
📖 Documentation 📖
https://sites.ecmwf.int/docs/dev-section/odc/pull-requests/PR-48