Skip to content

Add support for named kernel variants #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bleggett wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −1
Open

Add support for named kernel variants #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion protect/control/v1/control.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
rpc ImportImage(stream ImportImageRequest) returns (stream ImportImageReply);
rpc RemoveImage(RemoveImageRequest) returns (RemoveImageReply);
rpc ListImages(ListImagesRequest) returns (stream ListImagesReply);
rpc ListKernelVariants(ListKernelVariantsRequest) returns (ListKernelVariantsReply);

rpc CreateZone(CreateZoneRequest) returns (CreateZoneReply);
rpc DestroyZone(DestroyZoneRequest) returns (DestroyZoneReply);
Expand Down Expand Up @@ -641,7 +642,13 @@
// for moving tags) instead of resolving from the local cache.
// Set `want_metadata` to receive the OCI manifest/config in the final reply.
message PullImageRequest {
string image = 1;
// The image to pull, given either as a literal OCI reference or as a named
// kernel variant OCI alias the daemon resolves from its `[zone.kernel-variants]`
// mapping in daemon.toml.
oneof source {
string image = 1;

Check failure on line 649 in protect/control/v1/control.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "image" on message "PullImageRequest" moved from outside to inside a oneof.

Check failure on line 649 in protect/control/v1/control.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "image" on message "PullImageRequest" changed cardinality from "optional with implicit presence" to "optional with explicit presence".
string kernel_variant = 7;
}
OciImageFormat format = 2;
bool overwrite_cache = 3;
bool update = 4;
Expand All @@ -657,6 +664,22 @@
OciImageMetadata metadata = 3;
}

// Lists the named zone kernel variants the daemon can resolve, as configured under
// `[zone.kernel-variants]` in daemon.toml. These are the names accepted by the
// `--kernel-variant` / `dev.edera/kernel-variant` selectors.
message ListKernelVariantsRequest {}

message ListKernelVariantsReply {
repeated KernelVariant variants = 1;
}

// A single named kernel variant: the selectable `name` and the OCI reference
// the daemon resolves it to.
message KernelVariant {
string name = 1;
string image = 2;
}

// Client stream message for `ImportImage`: uploads an image archive directly into the
// local image cache, as a sequence of `chunk`s with `last_chunk` set on the final one.
// The first message must carry `image`, `digest` and `format`, identifying the image
Expand Down
Loading