fix(perf): replace query rewrite with graph-indexed header#1178
Merged
Conversation
Theodus
added
the
DO NOT MERGE (needs decision)
Theodus
force-pushed
the
theodus/rewrite
branch
from
775752f to
bfdf215
Compare
tmigone
requested changes
Apr 15, 2026
| #[derive(Clone, Debug)] | ||
| pub struct IndexerResponse { | ||
| pub original_response: String, | ||
| pub indexer_response: String, |
Member
There was a problem hiding this comment.
I think we no longer need to have both indexer_response and client_response, this was needed before when one of them had the gateway probe meta query response, but now these two are the same.
Member
There was a problem hiding this comment.
We should probably remove client_response
Theodus
removed
the
DO NOT MERGE (needs decision)
tmigone
approved these changes
Apr 15, 2026
Theodus
force-pushed
the
theodus/rewrite
branch
2 times, most recently
from
3f533fc to
61baee2
Compare
Theodus
force-pushed
the
theodus/rewrite
branch
from
61baee2 to
6db21f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This remove rewrites that insert an additional
_metaquery to probe indexing progress on every query. Assuming sufficient indexer support for thegraph-indexedheader, then this should be a safe removal.Resolves #900