fix: remove double definition for scorm#187
Merged
Merged
Conversation
MoisesGSalas
force-pushed
the
mgs/fix-caddy-scorm-error
branch
from
e47345a to
63c69cc
Compare
Add a small static check for the Caddyfile and set a default value for default_site_port for the catch all rule.
MoisesGSalas
force-pushed
the
mgs/fix-caddy-scorm-error
branch
from
63c69cc to
20439a3
Compare
DonatoBD
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catch all rule now includes the
caddyfile-lmspatch since #185 which caused the scorm_matcher to appear twice. We remove the scorm_matcher block from the catch-all rule and rely on the contents ofcaddyfile-lms.This also adds a small verification of the caddyfile syntax using
caddy validate.