Sort memory fix#38
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the badge workflow session lookup to avoid MySQL sort-buffer exhaustion by preventing the large metadata column from being included in the sorted result set.
Changes:
- Changes the session selection query to first fetch only the earliest matching session’s primary key (
id). - Loads the full
AIWorkflowSessionrow in a second step using the fetched PK.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
felipemontoya
force-pushed
the
fmo/mem-sort
branch
from
08cba33 to
1198345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes "Out of sort memory, consider increasing server sort buffer size"
Turns that mysql was loading the entire metadata field in the sort memory. Now it only does the create date and the ID