loose mask#196
Open
jxd136 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR loosens the submission import allowlist in the official evaluator so contestants may use the public Action enum and N_ACTIONS constant from GameLogic, while continuing to block other GameLogic internals. It also deletes the prior reference submission/agent.py and updates a test to exercise the new allowed import.
Changes:
- Allow
from GameLogic import Action, N_ACTIONSin submissions; keep all other GameLogic imports blocked, with clearer error messages. - Update
test_agent_source_allows_documented_env_methodsto import and useAction/N_ACTIONS. - Delete the large reference
logic/pve/submission/agent.py(and refresh checked‑in C# build artifacts).
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| logic/pve/official_evaluator.py | Adds _ALLOWED_GAMELOGIC_IMPORTS and refines the ImportFrom/Import checks to permit Action/N_ACTIONS while still rejecting other GameLogic imports. |
| logic/pve/tests/test_official_evaluator_rules.py | Extends an existing positive test to also import Action/N_ACTIONS from GameLogic. |
| logic/pve/submission/agent.py | Deletes the prior reference agent implementation. |
| playback/.../playback.AssemblyInfo*.cache/.cs | Regenerated MSBuild artifacts (commit hash bump). |
| installer/.../installer.AssemblyInfo*.cache/.cs | Regenerated MSBuild artifacts (commit hash bump). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of this pull request:
No additional description.