[kolide] Add GCS input and new data streams#20108
Conversation
Elastic Docs Style Checker (Vale)Summary: 2 warnings, 8 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/kolide/data_stream/deprovisioned_person/manifest.yml | 13 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/kolide/data_stream/osquery_result/fields/fields.yml | 8 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
💡 Suggestions (8): Optional style improvements. Apply when helpful.
| File | Line | Rule | Message |
|---|---|---|---|
| packages/kolide/_dev/build/docs/README.md | 79 | Elastic.WordChoice | Consider using 'efficient, basic' instead of 'Simple', unless the term is in the UI. |
| packages/kolide/_dev/build/docs/README.md | 235 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/kolide/_dev/build/docs/README.md | 351 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/kolide/data_stream/deprovisioned_person/fields/fields.yml | 13 | Elastic.Wordiness | Consider using 'before' instead of 'prior to'. |
| packages/kolide/data_stream/osquery_result/manifest.yml | 50 | Elastic.Ellipses | In general, don't use an ellipsis. |
| packages/kolide/data_stream/osquery_result/manifest.yml | 50 | Elastic.Wordiness | Consider using 'all' instead of 'all of '. |
| packages/kolide/data_stream/osquery_status/manifest.yml | 50 | Elastic.Ellipses | In general, don't use an ellipsis. |
| packages/kolide/data_stream/osquery_status/manifest.yml | 50 | Elastic.Wordiness | Consider using 'all' instead of 'all of '. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
Kolide's Log Pipeline can now be collected from Google Cloud Storage in addition to AWS S3, so customers who route their exported logs through GCS were previously unable to use this integration. Add a `gcs` input across the audit, auth, device_check, osquery_result, and osquery_status data streams, mirroring the existing `aws-s3` input templates. Add `osquery_result` and `osquery_status` data streams to cover the raw osquery logs in the Log Pipeline, which had no ingest path at all before this change. Add `deprovisioned_person`, `people`, and `request` data streams to fill remaining gaps in the REST API and webhook event coverage, and route the two new `requests.*` webhook event types to the new `request` data stream. Also fix `@timestamp` derivation in the issues pipeline: it previously used `detected_at` only, so a webhook-triggered re-fetch of an issue that had since been resolved or blocked kept the document's timestamp pinned to the original detection time. It now takes the max of detected_at/resolved_at/blocks_device_at (capped at ingest time, since blocks_device_at is a future enforcement deadline) and folds those fields into the document `_id` fingerprint so lifecycle updates don't collide on the same document. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
9da008d to
433254a
Compare
This comment has been minimized.
This comment has been minimized.
TL;DRThe Remediation
Investigation detailsRoot CauseAt the failed commit Evidence
VerificationNot run; this workflow is read-only and cannot modify the PR or rerun Buildkite. Follow-upThe PR head advanced to What is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
f54ccd5 to
a487941
Compare
a487941 to
50fccb7
Compare
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
ilyannn
left a comment
There was a problem hiding this comment.
🤖 Comment produced by Cursor/GPT-5.6 Sol under my supervision
Requesting changes for the ten actionable findings identified in the integration review. Local validation passed lint, check, and all 38 pipeline checks; the comments focus on runtime correctness, upgrade behavior, test coverage, documentation, mappings, and fixture sanitization.
|
No issues across the latest commits 0e7f104. Review summaryIssues found across earlier commits eaa7d2e — 1 high, 1 medium, 1 low
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
ilyannn
left a comment
There was a problem hiding this comment.
Looks good, though i still had some questions about the _id fingerprinting and whether it's a good idea to change it – can you talk to someone else who knows Kolide?
Also please re-check the proposed commit message, it seems outdated.
|
Tick the box to add this pull request to the merge queue (same as
|
|
After a call, duplication should not be an issue because the queries and dashboards should group by issue id. |
f983392 to
7612d70
Compare
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
|
Package kolide - 0.2.0 containing this change is available at https://epr.elastic.co/package/kolide/0.2.0/ |
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
osquery_result/osquery_statusAWS S3 and GCS ingest pipelines handle both the file formats present in real Kolide Log Pipeline exports.requestanddeprovisioned_persondata streams.How to test this PR locally
elastic-package checkfrompackages/kolide.elastic-package test system --config-file _dev/test/system/test-gcs-config.yml -d <data_stream>elastic-package test system --config-file _dev/test/system/test-default-config.yml -d <data_stream>elastic-package test pipeline -d <data_stream>elastic-package build && elastic-package installand manually check the Kolide dashboard against sample data.Related issues
Screenshots