Skip to content

feat(ep-commerce): add EPClearRefinements + EPCurrentRefinements (#315)#316

Merged
field123 merged 1 commit into
masterfrom
feat/ep-clear-current-refinements
May 5, 2026
Merged

feat(ep-commerce): add EPClearRefinements + EPCurrentRefinements (#315)#316
field123 merged 1 commit into
masterfrom
feat/ep-clear-current-refinements

Conversation

@field123
Copy link
Copy Markdown
Collaborator

@field123 field123 commented May 5, 2026

Summary

Closes

Test plan

  • yarn jest plasmicpkgs/commerce-providers/elastic-path — 119 catalog-search tests + 5 helper tests pass (1587 EP-package tests overall)
  • Verified end-to-end on examples/ep-commerce-app-router /products:
    • No filters → both Clear all and chip row hidden
    • 1 filter applied → 1 chip rendered with Tags: example (dynamic, title-cased), Clear all visible
    • 2 filters applied → 2 chips, click first chip removes only that filter
    • Clear all click → all filters cleared, controls auto-hide
  • CI green

Out of scope (per PRD)

  • Other items from feat(ep-commerce): catalog-search component coverage gaps #304 (autocomplete, hits-per-page, infinite hits, menu, toggle, numeric-menu, search-empty, hitsPerPage semantics fix)
  • Pagination retro split into atomic Prev/Next/Indicator (separate follow-up)
  • Backporting Pattern C improvements to AddToCartButton in @plasmicpkgs/commerce

Ships items #1 and #2 of #304 — single-click clear-all + active-filter
chip row for catalog search — and introduces the wrapper-onClick
pattern so designers get working defaults without manual interaction
wiring.

Also extracts cloneWithInjectedHandlers helper as a deep module for
future Pattern C adoption, and lazy-imports swr inside seedCartFallback
so the Next.js middleware bundle no longer pulls swr/react.createContext
into its module-evaluation phase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant