You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe this was caused by not having the escape character when the codesign command string was being constructed; therefore, causing the codesign command to fail when codesigning the executable e.g. App name.app/Contents/MacOS/App name
I was able to successfully codesign with electron-osx-sign with the change. I hope this resolves issues that others may have run into because their electron app product name has spaces.
I was merging the newer changes into my fork since I've made this PR. I see that the sign.js has been replaced with sign.ts. While, I was re-applying the changes from merging, I was going to improve string replace for the space character with the escape character to _opts.app using regex (https://stackoverflow.com/questions/44738314/escape-a-space-in-a-file-path-in-node-js) but realized, that with typescript the _opts i.e. SignOption is read-only, so this approach won't work. Perhaps, the more appropriate way is to update the documentation in the README.md that app with space is not supported and throw an exception during the validation in the util.ts in the validateOptsApp so it won't run into an error during the mac codesign process. Let me know if that approach is preferred and I'll make a commit to the README.md and util.ts instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created an issue: #237
I believe this was caused by not having the escape character when the codesign command string was being constructed; therefore, causing the codesign command to fail when codesigning the executable e.g.
App name.app/Contents/MacOS/App nameI was able to successfully codesign with electron-osx-sign with the change. I hope this resolves issues that others may have run into because their electron app product name has spaces.