fix: use :background_color key in embed adjust_transparency#209
Open
hlindset wants to merge 1 commit into
Open
fix: use :background_color key in embed adjust_transparency#209hlindset wants to merge 1 commit into
:background_color key in embed adjust_transparency#209hlindset wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a
KeyErrorinadjust_transparency/3. It tried to readoptions.backgroundinstead ofoptions.background_color. The bug only triggered onImage.embed/4withextend_mode: :backgroundon images with an alpha band, and 1-band images.P.S. It looks like there's a dead branch in there, because
Pixel.to_pixelalways padsbackground_colorto the image's full band count beforeadjust_transparencysees it, so length == bands is always true. Not fixed in this PR.image/lib/image/options/embed.ex
Lines 176 to 184 in 5bb98af
(code from current
main, so the key isn't fixed in the snippet)Would it make sense to merge
background_colorandbackground_transparencyinto a singleImage.Pixel-backedbackgroundoption, so the alpha rides on the color and the reconcile logic goes away? It should be possible to keep the color/transparency pair as a deprecated alternative that folds into the single key.