Refine Time.to_seconds_after_midnight/1 return type#15570
Merged
josevalim merged 1 commit intoJul 9, 2026
Conversation
The first tuple element is the number of seconds after midnight, which is
always in `[0, 86400)`: the implementation builds `iso_days = {0, ...}`
with the day count hardcoded to `0`, so `Calendar.ISO.iso_days_to_unit/2`
returns only the (non-negative) fraction-of-day part. The spec declared
the first element as the broad `integer()`; narrow it to `non_neg_integer()`
to match — the name and docstring ("seconds after midnight") already imply
a non-negative value.
Unlike `NaiveDateTime.to_gregorian_seconds/1`, which shares the same tuple
shape but whose first element is genuinely negative for pre-epoch instants,
here negatives are structurally impossible.
Assisted-by: Claude Code:claude-opus-4-8
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first tuple element is the number of seconds after midnight, which is always in
[0, 86400): the implementation buildsiso_days = {0, ...}with the day count hardcoded to0, soCalendar.ISO.iso_days_to_unit/2returns only the (non-negative) fraction-of-day part. The spec declared the first element as the broadinteger(); narrow it tonon_neg_integer()to match — the name and docstring ("seconds after midnight") already imply a non-negative value.Unlike
NaiveDateTime.to_gregorian_seconds/1, which shares the same tuple shape but whose first element is genuinely negative for pre-epoch instants, here negatives are structurally impossible.Assisted-by: Claude Code:claude-opus-4-8