Add missing calendar key to Calendar.time() and fix NaiveDateTime.truncate/2 spec#15572
Open
lukaszsamson wants to merge 1 commit into
Open
Add missing calendar key to Calendar.time() and fix NaiveDateTime.truncate/2 spec#15572lukaszsamson wants to merge 1 commit into
lukaszsamson wants to merge 1 commit into
Conversation
Found by re-running the type checker over function bodies with spec-derived argument domains (elixir-lang#15559): Calendar.time() was the only calendar-family type without a calendar: field (date, naive_datetime and datetime all declare it), yet virtually every Time function taking Calendar.time() destructures the field in its head -- to_string/1, to_iso8601/2, add/3, compare/2, shift/2, diff/3. A map conforming to the declared type therefore raised FunctionClauseError. Declare calendar: calendar like the sibling types. NaiveDateTime.truncate/2's second clause deliberately accepts any naive-datetime-compatible map (e.g. a DateTime), the same convention as add/3, to_date/1 and compare/2 -- but its spec said t(), making that clause unreachable per the spec. Accept Calendar.naive_datetime() like its siblings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by re-running the type checker over stdlib function bodies with spec-derived argument domains (the spec-domain body check from #15559):
Calendar.time()is the only calendar-family type without acalendar:field (date,naive_datetimeanddatetimeall declare it), yet virtually everyTimefunction takingCalendar.time()destructures the field in its head (to_string/1,to_iso8601/2,add/3,compare/2,shift/2,diff/3). A map conforming to the declared type raisesFunctionClauseErrortoday:Time.to_string(%{hour: 1, minute: 2, second: 3, microsecond: {0, 0}}). Declarecalendar: calendarlike the sibling types.NaiveDateTime.truncate/2's second clause deliberately accepts any naive-datetime-compatible map (e.g. aDateTime), the same convention asadd/3,to_date/1andcompare/2— but its spec saidt(), making that clause unreachable per the spec. NowCalendar.naive_datetime()like its siblings.The full stdlib recompiles with no new type-checker warnings under the tightened
time()type, and all calendar test suites pass.Assisted-By: Claude Fable 5
🤖 Generated with Claude Code