Accept chardata paths in Mix.Release.make_boot_script/4#15573
Open
lukaszsamson wants to merge 1 commit into
Open
Accept chardata paths in Mix.Release.make_boot_script/4#15573lukaszsamson wants to merge 1 commit into
lukaszsamson wants to merge 1 commit into
Conversation
Found by re-running the type checker over function bodies with spec-derived argument domains (elixir-lang#15559): the path argument is spec'd Path.t() (chardata), but the body applies <> and String.to_charlist/1 to it, so a charlist path -- valid per the spec -- raised ArgumentError. Normalize with IO.chardata_to_string/1 first, as the Path module functions do. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by re-running the type checker over stdlib function bodies with spec-derived argument domains (the spec-domain body check from #15559): the
pathargument is spec'dPath.t()(chardata), but the body applies<>andString.to_charlist/1to it, so a charlist path — valid per the spec — raisesArgumentError. Normalize withIO.chardata_to_string/1first, as thePathmodule functions do.Assisted-By: Claude Fable 5
🤖 Generated with Claude Code