Reject integer 0 in Float.round/2#15585
Merged
Merged
Conversation
josevalim
reviewed
Jul 10, 2026
pnezis
force-pushed
the
fix-float-round-integer-zero
branch
from
53c5950 to
3a58598
Compare
The zero shortcut clause guarded only on `float == 0.0`, and `0 == 0.0` is true under ==, so `Float.round(0)` and `Float.round(0, 0)` returned the integer 0 instead of raising, contradicting both the spec and the doc statement that the function only accepts floats and always returns a float. `Float.round(1)` and every other `Float` function already raised.
pnezis
force-pushed
the
fix-float-round-integer-zero
branch
from
3a58598 to
5eb6e9f
Compare
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zero shortcut clause guarded only on
float == 0.0, and0 == 0.0is true under ==, soFloat.round(0)andFloat.round(0, 0)returned the integer 0 instead of raising, contradicting both the spec and the doc statement that the function only accepts floats and always returns a float.Float.round(1)and every otherFloatfunction already raised.