Skip to content

Fix IEx completion crash on maps with non-atom keys #15612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jul 14, 2026
+6 −1
Merged

Fix IEx completion crash on maps with non-atom keys #15612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/iex/lib/iex/autocomplete.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ defmodule IEx.Autocomplete do
end)

entries =
for key when key != :__struct__ <- Map.keys(pairs),
for key when is_atom(key) and key != :__struct__ <- Map.keys(pairs),
name = Atom.to_string(key),
if(hint == "",
do: not String.starts_with?(name, "_"),
Expand Down
5 changes: 5 additions & 0 deletions lib/iex/test/iex/autocomplete_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,11 @@ defmodule IEx.AutocompleteTest do
assert {:no, [], []} = expand(~c"%{unknown | some: \"foo\", unkno")
end

test "completion for mixed type map keys in update syntax" do
eval("map = %{\"another\" => \"qwe\", some: 1, other: :ok}")
assert {:yes, ~c"me: ", []} = expand(~c"%{map | so")
end

test "completion for struct var keys" do
eval("struct = %IEx.AutocompleteTest.MyStruct{}")
assert expand(~c"struct.my") == {:yes, ~c"_val", []}
Expand Down
Loading