feat: add extension to setup fqdn for windows virtual machines - #2
Open
irinelbogdansp wants to merge 2 commits into
Open
feat: add extension to setup fqdn for windows virtual machines#2irinelbogdansp wants to merge 2 commits into
irinelbogdansp wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Release impact
A merge that touches
src/publishes a version. There is no staging branch between this pullrequest and a consumer's
terraform init. Docs- and CI-only changes do not release; they ride outwith the next module change. Pick one:
feat:; ships as aminor.
address, or tightened validation that previously accepted a working value. Still ships as a
minor or a patch; majors are cut deliberately, not inferred.
Checks run locally
terraform fmt -recursivepython .github/scripts/check-docs.pyterraform init -backend=false && terraform validatein each module toucheddocs/modules/and all fivecounts updated — see
adding a module
Anything reviewers should look at twice