Skip to content

feat: add extension to setup fqdn for windows virtual machines - #2

Open
irinelbogdansp wants to merge 2 commits into
emberstack:mainfrom
irinelbogdansp:feature/virtualmachine-fqdn
Open

feat: add extension to setup fqdn for windows virtual machines#2
irinelbogdansp wants to merge 2 commits into
emberstack:mainfrom
irinelbogdansp:feature/virtualmachine-fqdn

Conversation

@irinelbogdansp

@irinelbogdansp irinelbogdansp commented Jul 28, 2026

Copy link
Copy Markdown

What changed

Release impact

A merge that touches src/ publishes a version. There is no staging branch between this pull
request and a consumer's terraform init. Docs- and CI-only changes do not release; they ride out
with the next module change. Pick one:

  • Additive — a new module, a new optional input with a default. Title it feat:; ships as a
    minor.
  • Internal or corrective — a fix, a refactor, docs, CI, a dependency bump. Ships as a patch.
  • Breaking — renamed or removed an input or output, changed a default, changed a resource
    address, or tightened validation that previously accepted a working value. Still ships as a
    minor or a patch; majors are cut deliberately, not inferred.

⚠️ A breaking change does not bump the major here, so the release notes are the only place a
consumer will see it. Put BREAKING CHANGE: on its own line in a commit footer — the squashed body
keeps every commit message, so the footer survives wherever the subject came from. A ! is only
matched in the subject itself: the commit subject on a single-commit branch, the pull request title
when there are two or more. Unmarked, the break is invisible.

Checks run locally

  • terraform fmt -recursive
  • python .github/scripts/check-docs.py
  • terraform init -backend=false && terraform validate in each module touched
  • New module: added to the family guide in
    docs/modules/ and all five
    counts updated — see
    adding a module

Anything reviewers should look at twice

@irinelbogdansp irinelbogdansp changed the title Add virtual machine fqdn setup extension feat: add virtual machine fqdn setup extension Jul 28, 2026
@irinelbogdansp irinelbogdansp changed the title feat: add virtual machine fqdn setup extension feat: add extension to setup fqdn for windows virtual machines Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant