Fix lint tooling and isolate type-aware config#1108
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR restores/steadies the workspace lint + type-aware tooling by isolating Oxlint’s type-aware TypeScript configuration, removing a crashing JS-plugin integration, and adjusting @emdash-cms/registry-client’s typecheck flow to avoid the failing tsgo path.
Changes:
- Add a dedicated
tsconfig.oxlint.jsonand update root lint scripts to use it for type-aware Oxlint runs. - Remove
@e18e/eslint-pluginintegration + rules from.oxlintrc.json. - Switch
@emdash-cms/registry-client’stypechecktotsc --noEmitand tweak its TSlibsettings; simplify a redundant type annotation in plugin CLI.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tsconfig.oxlint.json |
Introduces a dedicated TS config for type-aware Oxlint runs with targeted excludes. |
package.json |
Points lint/lint:json/lint:fix at the dedicated oxlint tsconfig. |
.oxlintrc.json |
Removes the crashing jsPlugins integration and associated e18e/* rule configuration. |
packages/registry-client/package.json |
Changes typecheck to use tsc --noEmit instead of tsgo. |
packages/registry-client/tsconfig.json |
Drops esnext.typedarrays from lib. |
packages/plugin-cli/src/commands/info.ts |
Removes a redundant type annotation (keeps inferred type). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "$schema": "./node_modules/oxlint/configuration_schema.json", | ||
| "plugins": ["typescript", "import", "unicorn", "promise"], | ||
| "jsPlugins": ["@e18e/eslint-plugin"], | ||
| "categories": { |
There was a problem hiding this comment.
After removing the jsPlugins integration from .oxlintrc.json, @e18e/eslint-plugin was no longer used anywhere in the repo.
I removed it from package.json and updated the lockfile so the branch no longer installs an unused dependency.
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
|
Can you explain what this was fixing? I wasn't aware of it failing. |
This wasn't me fixing an already-red The concrete break I could point to was the oxlint config still referencing So the The If that reads broader than warranted, I'm happy to trim the PR down to just the minimal oxlint/config consistency fix. |
What does this PR do?
Restores the workspace lint/type-aware tooling path by isolating oxlint's type-aware config and avoiding a failing
tsgopath in@emdash-cms/registry-client.Closes #
tsconfig.oxlint.jsonfor type-aware oxlint runs.@emdash-cms/registry-clienttypecheck totsc --noEmit.packages/plugin-cli/src/commands/info.ts.@e18e/eslint-pluginJS-plugin integration fromoxlintconfig.Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
pnpm lintpasses with0errors on this branch.pnpm format:checkpasses.pnpm --filter @emdash-cms/registry-client typecheckpasses.pnpm typecheckcurrently hits an unrelated@emdash-cms/auth-atprotoimport-resolution failure present on top of current upstream and not touched by this PR.