[OpenAL] Fix sourceSeek crash on stopped sources - #26770
Open
uniformization wants to merge 3 commits into
Open
Conversation
sbc100
changed the title
sbc100
reviewed
Apr 24, 2026
sbc100
left a comment
sbc100
left a comment
Collaborator
There was a problem hiding this comment.
Could you maybe modify one of the existing tests in test_browser.py or test_inerative.py to cover this?
Author
@sbc100 I have added a test to |
sbc100
reviewed
Apr 25, 2026
Author
|
@sbc100 The issues have been resolved, let me know if the fix for the failing/passing the test is good |
sbc100
reviewed
Jul 27, 2026
| #endif | ||
| #else | ||
| usleep(700000); | ||
| playSource((void*)(sources[0])); |
Collaborator
There was a problem hiding this comment.
So in this mode you are calling playSource directly from the main function. Is it important for this test that you don't go via emscripten_async_call (like the !TEST_LOOPED_PLAYBACK case above?)
Author
There was a problem hiding this comment.
@sbc100 Yes, if unpatched, it will error, but the test will not fail if I call it through emscripten_async_call.
Collaborator
|
I did some research and came up with a slightly different fix/test: #27426. I'm happy to credit you as a co-author on that PR. What do you think of my alternative change? |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jul 28, 2026
Fix a crash in `sourceSeek` when called on a stopped source by resetting `bufsProcessed = 0` before evaluating buffer durations. This replaces emscripten-core#26770. Unlike emscripten-core#26770, which added a top-level check on `src.bufQueue[0]`, this change handles zero/dummy buffers and empty queues safely anywhere in `bufQueue` via `for .. of` iteration and `audioBuf?.duration ?? 0.0`. It also adds assertions to `test_openal_error.c` to verify state correctness after seeking. See: emscripten-core#26770
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jul 28, 2026
Fix a crash in `sourceSeek` when called on a stopped source by resetting `bufsProcessed = 0` before evaluating buffer durations. This replaces emscripten-core#26770. Unlike emscripten-core#26770, which added a top-level check on `src.bufQueue[0]`, this change handles zero/dummy buffers and empty queues safely anywhere in `bufQueue` via `for .. of` iteration and `audioBuf?.duration ?? 0.0`. It also adds assertions to `test_openal_error.c` to verify state correctness after seeking. See: emscripten-core#26770
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jul 28, 2026
Fix a crash in `sourceSeek` when called on a stopped source by resetting `bufsProcessed = 0` before evaluating buffer durations. This replaces emscripten-core#26770. Unlike emscripten-core#26770, which added a top-level check on `src.bufQueue[0]`, this change handles zero/dummy buffers and empty queues safely anywhere in `bufQueue` via `for .. of` iteration and `audioBuf?.duration ?? 0.0`. It also adds assertions to `test_openal_error.c` to verify state correctness after seeking. See: emscripten-core#26770
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jul 29, 2026
Fix a crash in `sourceSeek` when called on a stopped source by resetting `bufsProcessed = 0` before evaluating buffer durations. This replaces emscripten-core#26770. Unlike emscripten-core#26770, which added a top-level check on `src.bufQueue[0]`, this change handles zero/dummy buffers and empty queues safely anywhere in `bufQueue` via `for .. of` iteration and `audioBuf?.duration ?? 0.0`. It also adds assertions to `test_openal_error.c` to verify state correctness after seeking. See: emscripten-core#26770
sbc100
added a commit
that referenced
this pull request
Jul 29, 2026
Fix a crash in `sourceSeek` when called on a stopped source by resetting `bufsProcessed = 0` before evaluating buffer durations. This replaces #26770. Unlike #26770, which added a top-level check on `src.bufQueue[0]`, this change handles zero/dummy buffers and empty queues safely anywhere in `bufQueue` via `for .. of` iteration and `audioBuf?.duration ?? 0.0`. It also adds assertions to `test_openal_error.c` to verify state correctness after seeking. See: #26770
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you tried to use
AL_SEC_OFFSETon a stopped audio source, sourceSeek would throw aTypeErrorbecauseaudioBufwould be undefined.