Skip to content

allow pyi files#129

Merged
DerThorsten merged 3 commits into
mainfrom
add-exclude-patterns-for-scikit-image-in-config
Jun 11, 2026
Merged

allow pyi files#129
DerThorsten merged 3 commits into
mainfrom
add-exclude-patterns-for-scikit-image-in-config

Conversation

@DerThorsten

@DerThorsten DerThorsten commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

@DerThorsten DerThorsten changed the title add exclude patterns for scikit-image in config allow pyi files Jun 11, 2026

@martinRenou martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou added the bug Something isn't working label Jun 11, 2026
@DerThorsten

DerThorsten commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

I think we can ignore the failing itegration tests for now......the error is unrelated, seems to be some bitrotting and can be fixed in a differnt pr.

@bmorris3

Copy link
Copy Markdown

Thank you @DerThorsten!

Comment thread config/empack_config.yaml
- pattern: '**/*.exe'
- pattern: '**/*.c'
- pattern: '**/*.pxd'
- pattern: '**/*.pyi'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never would have figured this out on my own, thank you 🙏🏻

@DerThorsten DerThorsten merged commit 7045f07 into main Jun 11, 2026
5 of 7 checks passed
@martinRenou martinRenou deleted the add-exclude-patterns-for-scikit-image-in-config branch June 11, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot import scikit-image

3 participants