fix(WMenu): removeItem() selects wrong item when currently-selected item is removed#247
Open
saddamr3e wants to merge 1 commit into
Open
fix(WMenu): removeItem() selects wrong item when currently-selected item is removed#247saddamr3e wants to merge 1 commit into
saddamr3e wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing
WMenuItem::setContents(), I noticed that updating the contents of the currently selected menu item changes the active selection.The reason is that
WMenu::removeItem()treats removal of the current item the same way as removing an item before it. As a result, the previous menu item becomes selected automatically, even though only the contents of the current item are being updated.This change clears the selection when the current item is removed instead of selecting the previous item. The existing behavior for removing items before the current selection is unchanged.
I also added a regression test to cover this case and prevent it from happening again.