CharacterRandomizer: Change hair and cloth colors too#2143
Open
manuq wants to merge 2 commits into
Open
Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/townies-hair-cloth/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
3dcff49 to
5850caf
Compare
Collaborator
Author
5850caf to
cfb3f4b
Compare
Do not rely on instance shader parameters for recoloring. Instead, make the material unique when a different recolor is needed. For instance, by duplicating the cel_shading_recolor_material.tres. Now the way to have the same recoloring in multiple sprites is to share the same material. Townie: have a duplicate copy of the cel shading recolor material. Apply it to all the parts.
Before, the shader swapped 3 colors: light, medium and dark. The script had a way to derive the light and dark colors from the medium one. And the key colors were 3 shades of green. Go back to the palette-swap shader reference [1] and only change variable names and comments. Townie asset: - Change the colors so skin is yellow and clothes are green. - Manually paint the contour lines of shapes, to a darker value of the fill color. This adds a 4th color to the cel shading, which will be mapped to a dark line or a light line, for more readability. - Export all PNG spritesheets. CelShadingRecolor: - Pass the two palettes to the shader. - Add lists of hair tones and clothes tones. The latter is rather arbitrary and could be improved in the future. - Export buttons to randomize the first 4 colors of the palette for the skin, the next 4 for the hair, and the last 4 for the clothes. [1] https://github.com/KoBeWi/Godot-Palette-Swap-Shader/blob/master/addons/PaletteSwapShader/SimplePaletteSwap.gdshader Resolve #2204
Collaborator
Author
|
This is now on top of #2163 The palette swap works now, but:
|
Collaborator
Author
|
Hmm from main it looks like Marie has changed compared with 3 weeks ago so maybe is fine to remove the TODO note and just call
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Before, the shader swapped 3 colors: light, medium and dark. The script had a
way to derive the light and dark colors from the medium one. And the key colors
were 3 shades of green.
Go back to the palette-swap shader reference [1] and only change variable names
and comments.
Townie asset:
Change the colors so skin is yellow and clothes are green.
Manually paint the contour lines of shapes, to a darker value of the fill
color. This adds a 4th color to the cel shading, which will be mapped to a
dark line or a light line, for more readability.
Export all PNG spritesheets.
CelShadingRecolor:
Pass the two palettes to the shader.
Add lists of hair tones and clothes tones. The latter is rather arbitrary and
could be improved in the future.
Export buttons to randomize the first 4 colors of the palette for the skin,
the next 4 for the hair, and the last 4 for the clothes.
[1] https://github.com/KoBeWi/Godot-Palette-Swap-Shader/blob/master/addons/PaletteSwapShader/SimplePaletteSwap.gdshader
Resolve #2204