ci: Generate Windows builds#2192
Open
wjt wants to merge 1 commit into
Open
Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/windows-build/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
changed the title
wjt
force-pushed
the
wjt/windows-build
branch
2 times, most recently
from
2fb1719 to
1457b87
Compare
wjt
changed the title
Fix a long-standing TODO about cloning with --filter. I tried it, couldn't make it work, and it doesn't seem worth thinking further about. Remove fetch-tags: true (which is redundant with fetch-depth). Factor out the clone-with-cached-lfs-objects steps to a composite action. Add an explicit toggle + implicit paths filter to control whether a Windows build is needed, similar to the Flatpak build. Add a Windows build step. Keep the GDScript diagnostics check in the always-run web workflow. Reorder that workflow and leave notes about why the GDScript diagnostics & "should Windows & Flatpak builds run?" steps are in the web build. I considered putting the two lines that build & push the Windows artifact into the web job. It would probably be a bit faster but I think it would make the pipeline harder to understand. I also expect further Windows-specific stuff in future (specifically: code-signing!) which will be clearer in a Windows-specific job. Resolves #2156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a long-standing TODO about cloning with --filter. I tried it,
couldn't make it work, and it doesn't seem worth thinking further about.
Remove fetch-tags: true (which is redundant with fetch-depth).
Factor out the clone-with-cached-lfs-objects steps to a composite
action.
Add an explicit toggle + implicit paths filter to control whether a
Windows build is needed, similar to the Flatpak build. Add a Windows
build step.
Keep the GDScript diagnostics check in the always-run web workflow.
Reorder that workflow and leave notes about why the GDScript diagnostics
& "should Windows & Flatpak builds run?" steps are in the web build.
I considered putting the two lines that build & push the Windows
artifact into the web job. It would probably be a bit faster but I think
it would make the pipeline harder to understand. I also expect further
Windows-specific stuff in future (specifically: code-signing!) which
will be clearer in a Windows-specific job.
Resolves #2156