Skip to content

Control-plane CLI: org/project get+delete, repo grant list+remove#1499

Open
entire[bot] wants to merge 13 commits into
feat/control-plane-friendly-namesfrom
feat/control-plane-crud-gaps
Open

Control-plane CLI: org/project get+delete, repo grant list+remove#1499
entire[bot] wants to merge 13 commits into
feat/control-plane-friendly-namesfrom
feat/control-plane-crud-gaps

Conversation

@entire

@entire entire Bot commented Jun 23, 2026 •
edited by toothbrush
Loading

Copy link
Copy Markdown

https://entire.io/gh/entireio/cli/trails/642

Consume the v1 CRUD-gap endpoints from entiredb #2122 (COR-561). Stacked on feat/control-plane-friendly-names — merge that first.

New verbs

  • entire org get|delete <name|ULID>
  • entire project get|delete <name|ULID>
  • entire grant repo list <repo>
  • entire grant repo remove <repo> — --provider/--provider-user-id or --grantee-type/--grantee-id

Friendly-name resolution

Org and project args resolve names via the resolveref helpers from the base branch. Repo args also resolve by name when scoped with --project <name|ULID> (repo names are unique only within a project); a ULID still passes through unchanged and ignores --project. Applies to repo get/delete and grant repo add/list/remove.

Client regen

Regenerated internal/coreapi from the updated Core API spec (GetOrg, DeleteOrg, GetProject, DeleteProject, ListRepoGrants, RevokeRepoAccess, RevokeRepoAccessByProvider). #2122 also made grant role a validated enum (reader/writer/admin), so grant add now validates --role and casts to the typed value.

Commits

  • regenerate coreapi client
  • adapt grant callers to typed role enum
  • add the six new verbs + tests
  • resolve repos by name with --project scope

Verified: fmt/lint clean, test:ci green (59 + 4).

@toothbrush toothbrush marked this pull request as ready for review June 23, 2026 08:20
@toothbrush toothbrush requested a review from a team as a code owner June 23, 2026 08:20
Copilot AI review requested due to automatic review settings June 23, 2026 08:20
Copilot AI reviewed Jun 23, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generated Core API client (internal/coreapi) to consume newly added v1 endpoints (org/project get+delete, repo grant list+revoke) and wires new CLI verbs under the hidden control-plane command groups (entire org, entire project, entire grant repo). It also introduces typed/validated grant role enums (reader/writer/admin) and adds unit tests for the new resolver/flag-validation helpers.

Changes:

  • Regenerate internal/coreapi from an updated OpenAPI spec, adding org/project get+delete and repo grant list/revoke operations, plus typed role enums.
  • Add new CLI verbs: entire org get|delete, entire project get|delete, entire grant repo list|remove, and validate/cast --role for project/repo grants.
  • Add repo-name resolution helper (resolveRepoRef) gated by --project, plus unit tests for repo picking and grant-role/grantee-mode parsing.

Reviewed changes

Copilot reviewed 8 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/coreapi/spec/core.openapi.json OpenAPI spec update adding new endpoints and role enums.
internal/coreapi/spec/core.gen.json Generated schema update reflecting enum roles and new response shapes.
internal/coreapi/oas_validators_gen.go Generated validators updated for typed role enums + new output bodies.
internal/coreapi/oas_security_gen.go Generated auth/role maps updated for new operations.
internal/coreapi/oas_schemas_gen.go Generated Go types updated (typed roles; new request/response structs).
internal/coreapi/oas_response_decoders_gen.go Generated HTTP response decoders added for new endpoints.
internal/coreapi/oas_parameters_gen.go Generated parameter structs added for new endpoints.
internal/coreapi/oas_operations_gen.go Generated operation constants added for new endpoints.
internal/coreapi/oas_json_gen.go Generated JSON encode/decode updated for typed roles and new schemas.
cmd/entire/cli/resolveref.go Add resolveRepoRef/pickRepo to resolve repo names with --project scope.
cmd/entire/cli/resolveref_test.go Unit tests for pickRepo (plus existing resolver helper coverage).
cmd/entire/cli/repo.go Repo get/delete now accept name-or-ULID with optional --project for name resolution.
cmd/entire/cli/project.go Add project get and project delete commands using name/ULID resolution.
cmd/entire/cli/org.go Add org get and org delete commands using name/ULID resolution.
cmd/entire/cli/grant.go Validate/cast grant roles; add grant repo list/remove; reuse repo resolution with --project.
cmd/entire/cli/grant_test.go Unit tests for validateGrantRole and parseGranteeMode rename/behavior.
Files not reviewed (7)
  • internal/coreapi/oas_json_gen.go: Generated file
  • internal/coreapi/oas_operations_gen.go: Generated file
  • internal/coreapi/oas_parameters_gen.go: Generated file
  • internal/coreapi/oas_response_decoders_gen.go: Generated file
  • internal/coreapi/oas_schemas_gen.go: Generated file
  • internal/coreapi/oas_security_gen.go: Generated file
  • internal/coreapi/oas_validators_gen.go: Generated file

Comment thread cmd/entire/cli/resolveref.go
@toothbrush toothbrush force-pushed the feat/control-plane-crud-gaps branch from 7dc26c0 to 41bc806 Compare June 23, 2026 08:30
@toothbrush toothbrush force-pushed the feat/control-plane-friendly-names branch from d08809d to 789678d Compare June 24, 2026 05:06
@toothbrush toothbrush force-pushed the feat/control-plane-crud-gaps branch from a96d4d2 to 2749cb4 Compare June 24, 2026 05:07
toothbrush and others added 13 commits June 24, 2026 14:59
@toothbrush @claude
chore(coreapi): regenerate client for v1 CRUD-gap endpoints
f7a07c9 
Refresh the generated control-plane client from the updated Core API
spec (entiredb #2122 / COR-561), adding GetOrg, DeleteOrg, GetProject,
DeleteProject, ListRepoGrants, RevokeRepoAccess, and
RevokeRepoAccessByProvider. Generated via `go generate ./internal/coreapi/...`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@toothbrush @claude
fix(grant): adapt to typed grant-role enum from regenerated client
41fa1fe 
#2122 made the v1 grant role a validated enum (reader/writer/admin), so
the regenerated client types GrantProjectAccess/GrantRepoAccess Role
fields as enums rather than string. Validate --role at the CLI boundary
and cast to the typed value.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: e9918e472c9d
@toothbrush @claude
feat(control-plane): add org/project get+delete and repo grant list+r…
016a44f 
…emove

Consume the v1 CRUD-gap endpoints (entiredb #2122):

- entire org get|delete <name|ULID>
- entire project get|delete <name|ULID>
- entire grant repo list <repo>
- entire grant repo remove <repo> (--provider/--provider-user-id or
  --grantee-type/--grantee-id)

Org/project args resolve friendly names via the shared resolveref helpers.
The grantee-mode helper (renamed parseGranteeMode) and the
provider/by-id remove form are now shared by project and repo. Repo args
stay ULID-only for now — resolving a repo by name needs a project scope.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: a995fb3417fb
@toothbrush @claude
feat(control-plane): resolve repos by name with --project scope
ec08c2b 
repo get/delete and grant repo add/list/remove now accept a repo name
(not just a ULID) when --project <name|ULID> is given to scope the
lookup — repo names are unique only within a project. A ULID still
passes through unchanged and ignores --project.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: ab8e423ff72f
@toothbrush @claude
feat(control-plane): consume paginated v1 list endpoints (COR-580)
13b730f 
entire-core's v1 list endpoints now return keyset pages (limit/cursor +
nextCursor) and cap page size at 50, and orgs/repos gained O(1) ?name=
lookups. Regenerate the client against the refreshed spec and update the
consumers:

  - fetchAllPages: a cursor-following helper; every list command (org/
    project/repo list, grant org/project/repo list) now walks all pages
    instead of silently showing only the first 50.
  - resolveOrgRef/resolveRepoRef: resolve names via the server's O(1)
    ?name= lookup (single org/repo response) rather than listing+scanning,
    which would now miss a target past page 1.
  - resolveProjectRef and `project list --name`: read the single `project`
    field the ?name= response actually returns (was reading the empty
    `projects` list — a latent miss).
  - drop the now-unused client-side pickOrg/pickProject/pickRepo matchers.

Spec refreshed from entiredb main (also narrows grant granteeType to
account-only, already enforced server-side).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@toothbrush @claude
feat(control-plane): rename pagination params to pageToken convention
51d1d88 
entire-core renamed the v1 list pagination params to match the data-plane
convention (cursor → pageToken, nextCursor → nextPageToken). Regenerate the
client and follow suit in the page-walking call sites.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@toothbrush @claude
chore(coreapi): regenerate client for PageInput/PageMeta pagination
c2ff634 
entire-core consolidated the v1 list endpoints onto the shared
PageInput/PageMeta types: the page-size param moved limit → pageSize
(max 500). Regenerate the client; the page-walking call sites only set
pageToken, so no consumer changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@toothbrush @claude
feat(control-plane): paginate repo mirror list (COR-583)
e6a7ddb 
COR-583 paginates the remaining v1 list endpoints on the same
PageInput/PageMeta dialect. Of those, the CLI consumes only ListMirrors:
wrap `repo mirror list` in fetchAllPages so it walks every page instead of
showing the first 50. Regenerate the client against the refreshed spec
(audit/oidc-providers/service-accounts/bindings/lookup-resources gain
pagination too, but no CLI command consumes them yet).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@toothbrush @claude
chore(control-plane): address PR review (grantee-type, paging comment…
d2d91e3 
…, parallel tests)

- grant {project,repo} add: the control plane (and the regenerated client
  enum) accept only granteeType=account now (org/team granting was dropped
  server-side, COR-561). Validate --grantee-type at the CLI with a clear
  message instead of an opaque enum-encoding error, and correct the
  flag/Long help that still advertised org/team (add + revoke).
- fetchAllPages: drop the hard-coded "max 200" from the doc comment; the
  server caps page size and may cap further, so phrase it generically.
- resolver tests: add t.Parallel() to match the file's convention (each
  builds its own httptest server; no shared global state).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@toothbrush @claude
fix(control-plane): show resolved ULID in delete success messages
fc2ac04 
org/project/repo delete echoed the user-supplied arg, so a name-based
delete confirmed a name while the operation used the resolved ULID —
ambiguous where names are reused. Add resolvedRefLabel to render
"name (ULID)" for names and the bare ULID otherwise.

Addresses trail #642 finding.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: c14749e12a9d
@toothbrush @claude
feat(control-plane): confirm destructive org/project/repo delete
15df8e9 
org/project/repo delete called the destructive API immediately after
resolving the ref — a name typo that resolves to a real resource (or a
wrong-but-valid ULID) deleted silently. Gate each behind a confirmation
prompt (the existing trail-delete pattern) with a --force/-f bypass and
--yes/-y alias; non-interactive runs refuse without --force rather than
deleting unprompted. Shared body extracted to runControlPlaneDelete.

Addresses trail #642 finding.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 5201fa5dc67c
@toothbrush @claude
feat(control-plane): idempotent deletes + command-level wiring tests
ed45929 
- org/project/repo delete now treat a 404 from the delete call as the
  desired end state (already gone), printing "<noun> <label> not found;
  nothing to delete" instead of surfacing a raw 404.
- Add command-level tests driving each delete command through cobra
  against a fake control plane: --force issues DELETE on the right path,
  an already-gone resource is idempotent, and a non-interactive run
  without --force refuses rather than deleting unprompted.

Addresses trail #642 findings.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 416181183067
@toothbrush @claude
chore(control-plane): reconcile crud-gaps work onto friendly-names re…
2d4b58a 
…solver

Rebased onto feat/control-plane-friendly-names, which had independently
reworked name resolution to the client-side pickOrg/pickProject design.
Kept that resolver and dropped crud-gaps' server-side ?name= variant; this
pass adapts the seams:
- resolveOrgRef walks all pages (ListOrgs is now paginated) then pickOrg
- restore isNotFound + resolvedRefLabel helpers used by the delete commands
- writeNotFoundProblem test helper (friendly-names' resolver tests lack it)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: ae2378c10239
@toothbrush toothbrush force-pushed the feat/control-plane-crud-gaps branch from 2749cb4 to 2d4b58a Compare June 24, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toothbrush toothbrush toothbrush left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toothbrush