Skip to content

Upload toolshed-echo OCI artifacts with a distinct release collector path - #4991

Draft
phlax with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-toolshed-echo-upload-artifact
Draft

Upload toolshed-echo OCI artifacts with a distinct release collector path#4991
phlax with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-toolshed-echo-upload-artifact

Conversation

Copilot AI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

toolshed-echo was included in the Docker release manifest config, but its OCI tarball was never uploaded from Docker CI, so the release collector had nothing to extract and buildah manifest add failed on a missing index.json. The fix wires the echo tar into the same artifact flow used for release publishing, while avoiding artifact-name collisions with the existing image build job.

  • Root cause

    • echo built docker/build/oci-output/toolshed-echo-v{echo-version}-{arch}.tar and smoke-tested it, but never uploaded it as a workflow artifact.
    • The release collector expected that tar via .github/docker-manifests.yml, so publish had no extracted OCI layout to read.
  • Workflow wiring

    • Added Upload OCI artifacts to the end of the echo job in .github/workflows/_docker.yml.
    • Kept the existing upload action pin and upload shape (docker/build/oci-output/*.tar, retention 1 day, fail if missing).
  • Artifact collision handling

    • build and echo run in the same Docker CI workflow run via the arch × target matrix in .github/workflows/docker.yml.
    • Because upload-artifact@v4+ does not merge duplicate artifact names, the echo upload uses a distinct artifact name:
      • oci-debian-echo-${{ inputs.arch }}
    • Updated the toolshed-echo manifest entry to match that artifact directory:
      • oci-debian-echo-{arch}/toolshed-echo-v{echo-version}-{arch}.tar
  • Architecture coverage

    • The existing Docker CI matrix already runs echo for both amd64 and arm64, so both tarballs now land in the release collector input set.
- name: Upload OCI artifacts
  uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
  with:
    name: oci-debian-echo-${{ inputs.arch }}
    path: docker/build/oci-output/*.tar
    retention-days: 1
    if-no-files-found: error

@netlify

netlify Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deploy Preview for nifty-bassi-e26446 ready!

Name Link
🔨 Latest commit 4ee965f
🔍 Latest deploy log https://app.netlify.com/projects/nifty-bassi-e26446/deploys/6a776babe81e370008d74c8a
😎 Deploy Preview https://deploy-preview-4991--nifty-bassi-e26446.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix toolshed-echo upload artifact in Docker workflow Upload toolshed-echo OCI artifacts with a distinct release collector path Aug 8, 2026
Copilot AI requested a review from phlax August 8, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants