Skip to content

SeerSourceSymbolLibraryManagerWidget: Add close un-used tabs option#440

Merged
epasveer merged 7 commits intoepasveer:mainfrom
QuangNguyenMinh123:feature/Close_Source_unused_tabs
Mar 17, 2026
Merged

SeerSourceSymbolLibraryManagerWidget: Add close un-used tabs option#440
epasveer merged 7 commits intoepasveer:mainfrom
QuangNguyenMinh123:feature/Close_Source_unused_tabs

Conversation

@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor

As disscuss in issues #439, this MR will add option to SeerSourceSymbolLibraryManagerWidget so that users can close any tab that they don't use
This MR haven't deploy QSetting as I’m going to spend some time focusing on integrating openocd into seer
So, @epasveer, if you please, help me to deploy QSetting to this MR

@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

To clarify, I add _dumpTab variable to tabWidget
If I don't then when all tab is set to setTabVisible(0), the following bug will occur:
Screencast from 03-12-2026 10:20:58 PM.webm

Try for yourself

@epasveer
Copy link
Copy Markdown
Owner

So, @epasveer, if you please, help me to deploy QSetting to this MR

Will do!

@epasveer
Copy link
Copy Markdown
Owner

To clarify, I add _dumpTab variable to tabWidget

To be honest, I'm okay with the new logic to enforce having at least 1 tab enabled. I'll try that instead of adding a "_dumpTab" variable.

@epasveer
Copy link
Copy Markdown
Owner

Also, I'll do all sections, not just the SourceSymbol section.

And, of course, making things persist to QSettings.

@epasveer
Copy link
Copy Markdown
Owner

Give this MR a try. I've made some changes.

I've removed the need for the "dummy" tab. And it persists to QSettings.

@epasveer
Copy link
Copy Markdown
Owner

I modified all the other "managers" with the same changes. It works very well.

Thanks for the suggestion!

@QuangNguyenMinh123 QuangNguyenMinh123 marked this pull request as ready for review March 17, 2026 17:48
@QuangNguyenMinh123
Copy link
Copy Markdown
Contributor Author

I checked out and tried your commit
It seems to work well
Thanks for your hard works

@epasveer
Copy link
Copy Markdown
Owner

Found a bug with recursion. Updated a fix.

@epasveer epasveer merged commit 2373079 into epasveer:main Mar 17, 2026
1 check passed
@epasveer
Copy link
Copy Markdown
Owner

Found a bug with recursion. Updated a fix.

Actually, my fix was rubbish. I made the proper fix in the main line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants