Skip to content

Fix Windows npm start spawning in early solution tests#8

Merged
cursor[bot] merged 2 commits into
mainfrom
cursor/fix-windows-npm-start-495a
Jul 6, 2026
Merged

Fix Windows npm start spawning in early solution tests#8
cursor[bot] merged 2 commits into
mainfrom
cursor/fix-windows-npm-start-495a

Conversation

@kentcdodds

@kentcdodds kentcdodds commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a shared getNpmStartOutput helper for expression/output solution tests
  • Run npm start --silent through a shell consistently so npm command shims resolve across platforms
  • Replace duplicated spawnSync('npm', ...) test boilerplate with the shared helper for the affected post-Hello-World tests

Verification

  • PATH="/home/ubuntu/.nvm/versions/node/v22.18.0/bin:$PATH"; node -v && npm run typecheck && node ./epicshop/test.js ..s

All 26 solution test suites passed. Problem test suites were not included.

Open in Web Open in Cursor 

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@kentcdodds kentcdodds marked this pull request as ready for review July 6, 2026 19:08
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@cursor cursor Bot merged commit b99d9a5 into main Jul 6, 2026
6 checks passed

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0aed4d1. Configure here.

}

const output = getOutput()
const output = getNpmStartOutput()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playground missing shared test helper

High Severity

Solution tests now import getNpmStartOutput from ../run-npm-start.ts, but the Epic Shop playground only receives copied *.test.ts files into a flat playground/ directory. That relative import resolves outside the playground and the helper file is not present, so npm test in the playground fails to load the module for exercises 2–5.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0aed4d1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants