Fix after_cashback_amount_total to use the line total#287
Open
josecarneiro wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In applyDiscounts, the cashback branch computed after_cashback_amount_total from the per-unit gross amount instead of the line total:
afterCashbackAmountTotal = unitAmountGross.subtract(normalizedCashbackAmount);
When the quantity multiplier is 1, unit_amount_gross === amount_total, so the result was correct by coincidence. But when the unit amount is multiplied by a quantity/consumption (so amount_total = unit_amount_gross × multiplier), subtracting the full cashback from the small per-unit figure produced wrong — often negative — totals. This also left the item-level value inconsistent with the recurrence-level after_cashback_amount_total, which was already derived from the total.
Fix
Deduct the cashback from amount_total. Item-level and recurrence-level values now reconcile (the item afters sum to the recurrence after).
Only after_cashback_amount_total changes, and only when the multiplier ≠ 1; it's a leaf output, so aggregates are unaffected.