fix: guard NiPoPow scorex_parse against allocation bomb#855
Open
mwaddip wants to merge 1 commit into
Open
Conversation
…d input A crafted P2P payload could set num_prefixes/num_suffix_tail to 0x7FFFFFFF, causing Vec::with_capacity to request ~790 GB and SIGABRT the node. Add sanity caps to all five attacker-controlled size fields in NipopowProof::scorex_parse and PoPowHeader::scorex_parse. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kushti
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
num_prefixesor other size fields to0x7FFFFFFF, causingVec::with_capacityto request ~790 GB and SIGABRT the nodeNipopowProof::scorex_parseandPoPowHeader::scorex_parseErrinstead of crashingGuarded fields
NipopowProof::scorex_parsenum_prefixesNipopowProof::scorex_parsenum_suffix_tailPoPowHeader::scorex_parseheader_sizePoPowHeader::scorex_parseinterlinks_sizePoPowHeader::scorex_parseproof_bytesTest plan
crafted_huge_prefix_count_returns_err—num_prefixes = 0x7FFFFFFF→Errcrafted_huge_header_size_returns_err—header_size = 0x7FFFFFFF→Errcrafted_header_size_just_over_limit_returns_err—header_size = 10,001→Errnipopowproof_roundtripproptest still passes🤖 Generated with Claude Code