fix: Correct eval model_config and RBAC pass-through for CD pipeline#2
Merged
Merged
Conversation
- Fix GroundednessEvaluator model_config validation failure by adding azure_deployment and credential params (was missing both) - Extract base AI Services endpoint from project endpoint URL (evaluators need account-level endpoint, not project-scoped) - Add configurable evaluation.model field to per-env agent configs - Pass deployerPrincipalId to foundryAccount Bicep module (was missing, preventing RBAC assignment for pipeline identity) - Update config SCHEMA.md with new evaluation.model field Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes evaluation configuration for real Foundry evaluator runs and passes the pipeline deployer identity into the Foundry account module for RBAC assignment.
Changes:
- Adds base AI Services endpoint extraction and configurable evaluator model wiring.
- Passes
deployerPrincipalIdinto the Foundry account Bicep module. - Documents and sets
evaluation.modelacross environment configs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/scripts/run_evaluation.py |
Adds evaluator endpoint/model configuration for real evaluations. |
infra/main.bicep |
Passes deployer principal ID to the Foundry account module. |
config/SCHEMA.md |
Documents the new optional evaluation.model field. |
config/agent-config.dev.json |
Sets the evaluation scoring model for dev. |
config/agent-config.test.json |
Sets the evaluation scoring model for test. |
config/agent-config.prod.json |
Sets the evaluation scoring model for prod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azure_deployment and credential params (was missing both)
(evaluators need account-level endpoint, not project-scoped)
preventing RBAC assignment for pipeline identity)
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com