execution/chain: remove TestChainConfig alias

[yperbasis]

Summary

• Remove the TestChainConfig alias (which was just TestChainBerlinConfig)
• Replace most references with AllProtocolChanges (the latest config with all protocol changes enabled)
• Tests that rely on pre-London behavior (no EIP-1559 base fee) use TestChainBerlinConfig directly instead

Test plan

• make erigon integration builds successfully
• make lint passes
• All affected test packages pass with -short

🤖 Generated with Claude Code

[Giulio2002]

LGTM — straightforward mechanical cleanup removing the TestChainConfig alias and updating tests/helpers to use the intended explicit configs.

[Copilot]

Pull request overview

This PR removes the chain.TestChainConfig alias and updates tests/utilities to explicitly use either chain.AllProtocolChanges (latest “all forks enabled” config) or chain.TestChainBerlinConfig for pre-London behavior.

Changes:

• Deleted the TestChainConfig alias and migrated call sites to AllProtocolChanges or TestChainBerlinConfig.
• Updated multiple unit tests/benchmarks/fuzz tests to run under the intended fork rules (post-forks vs pre-London).
• Adjusted several genesis/spec/test helper defaults to use explicit configs.

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
txnprovider/txpool/txpool_grpc_server_test.go	Use AllProtocolChanges when constructing the txpool in gRPC server tests.
txnprovider/txpool/pool_test.go	Switch txpool tests to AllProtocolChanges config.
txnprovider/txpool/pool_fuzz_test.go	Switch txpool fuzz tests to AllProtocolChanges config.
rpc/jsonrpc/receipts/handler_test.go	Use TestChainBerlinConfig for receipt tests requiring pre-London semantics.
rpc/jsonrpc/eth_system_test.go	Use TestChainBerlinConfig for gas price/system tests requiring pre-London semantics.
rpc/jsonrpc/eth_callMany_test.go	Update genesis config to AllProtocolChanges in eth_callMany tests.
rpc/jsonrpc/eth_call_test.go	Use TestChainBerlinConfig in call tests requiring pre-London behavior.
rpc/jsonrpc/erigon_receipts_test.go	Use TestChainBerlinConfig in receipts tests requiring pre-London behavior.
rpc/gasprice/gasprice_test.go	Mix of Berlin vs AllProtocolChanges updates for oracle tests and mock backend.
rpc/gasprice/bench_test.go	Benchmarks now use AllProtocolChanges.
execution/vm/instructions_test.go	EVM instruction tests now run under AllProtocolChanges.
execution/vm/gas_table_test.go	Use TestChainBerlinConfig in gas table tests that expect pre-London rules.
execution/types/block_test.go	Block tests now use LatestSigner(AllProtocolChanges).
execution/tracing/tracers/logger/logger2_test.go	Update (commented) example to refer to “AllProtocolChanges”.
execution/tracing/tracers/logger/logger_test.go	Logger tracer tests now use AllProtocolChanges.
execution/tracing/tracers/js/tracer_test.go	JS tracer tests now use AllProtocolChanges.
execution/tests/blockgen/chain_makers.go	Default nil config in chain generation now becomes AllProtocolChanges.
execution/tests/blockchain_test.go	Various execution tests now use explicit configs (mostly AllProtocolChanges, one Berlin).
execution/tests/block_validator_test.go	Header validation tests now use AllProtocolChanges.
execution/state/database_test.go	Use TestChainBerlinConfig where pre-London behavior is required.
execution/stagedsync/stage_senders_test.go	Stage senders tests now use AllProtocolChanges.
execution/protocol/misc/eip1559_test.go	EIP-1559 tests now derive from AllProtocolChanges.
execution/execmodule/moduleutil/grpc_test.go	Use LatestSigner(AllProtocolChanges) in grpc module util tests.
execution/execmodule/execmoduletester/exec_module_tester.go	Default tester config is now explicitly TestChainBerlinConfig (was alias).
execution/chain/spec/genesis.go	Test genesis now explicitly uses TestChainBerlinConfig.
execution/chain/spec/config.go	Test network spec now explicitly uses TestChainBerlinConfig.
execution/chain/chain_config.go	Remove the TestChainConfig alias.
execution/abi/bind/util_test.go	Bind util tests now use MakeSigner(AllProtocolChanges, ...).
execution/abi/bind/backends/simulated.go	Simulated backend now explicitly uses TestChainBerlinConfig (was alias).
execution/abi/bind/backends/simulated_test.go	Simulated backend tests updated to expect Berlin config explicitly.
db/snapshotsync/freezeblocks/dump_test.go	Dump tests now use AllProtocolChanges where applicable.
cmd/rpcdaemon/rpcdaemontest/test_util.go	rpcdaemon test utils now explicitly use TestChainBerlinConfig.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[yperbasis]

Race-test flakiness: TestExecutionSpecBlockchainDevnet/.../test_exact_coinbase_fee_simple_sstore

This test passed on the first CI run and failed on the third — the only code changes between runs were in blockchain_test.go and block_validator_test.go (completely separate packages from eest_devnet).

Failure: expects blockGasUsed=112704, gets 75136. Difference is exactly 37568 = 32 × 1174 — one SSTORE state gas charge under EIP-8037. The state gas dimension is not being counted.

Investigation: traced the full execution path — BlockGasUsed = max(BlockRegular, BlockState) → BlockState only populated when rules.IsAmsterdam → rules computed once per block from config → config is testforks.Forks["Amsterdam"] with AmsterdamTime: 0. All code paths are deterministic and single-threaded per block execution. No shared mutable state found.

Conclusion: pre-existing flaky race-test, not caused by this PR.