Skip to content

Fix embedded resource upgrade discovery and add server version UX#774

Merged
erikdarlingdata merged 1 commit intodevfrom
fix/772-embedded-upgrade-discovery
Apr 1, 2026
Merged

Fix embedded resource upgrade discovery and add server version UX#774
erikdarlingdata merged 1 commit intodevfrom
fix/772-embedded-upgrade-discovery

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

  • Root cause fix for [BUG] Invalid Column Name errors for collect.database_size_stats_collector #772: MSBuild mangles embedded resource names for upgrade folders (e.g., 2.2.0-to-2.3.0_2._2._0_to_2._3._0), which broke EmbeddedResourceScriptProvider — all Dashboard upgrades silently returned zero results
  • Server version visibility: Show installed Monitor version in NOC health cards, sidebar server list, and Manage Servers
  • Check for Updates UX: Added "Check for Updates" button to Edit Server dialog, "Check Server Version" to sidebar right-click and NOC card right-click menus
  • Dialog layout fix: Pin Save/Cancel buttons outside scroll area so they stay visible during long install/upgrade operations; allow dialog resizing

Test plan

  • Unit tests: 17 upgrade ordering tests pass (including new embedded resource regression test)
  • Integration test: Downloaded v2.2.0 release installer, installed on SQL2022, upgraded via Dashboard Edit Server — all 3 missing columns added, upgrade recorded as SUCCESS
  • Verified NOC cards show "Online — Monitor v2.5.0"
  • Verified sidebar shows "Monitor v2.5.0" for online servers
  • Verified right-click menus work from sidebar and NOC cards
  • Verified Edit Server "Check for Updates" detects version mismatch and offers upgrade
  • Verified buttons stay visible after upgrade completes

Fixes #772

🤖 Generated with Claude Code

MSBuild mangles embedded resource names for upgrade folders (e.g.,
"2.2.0-to-2.3.0" becomes "_2._2._0_to_2._3._0"), which caused
EmbeddedResourceScriptProvider to fail parsing all upgrade folders.
Dashboard upgrades silently returned zero results, so upgrade scripts
never ran and schema changes were missing.

Fix: use regex to match mangled names and unmangle back to original
folder names. Also surface installed Monitor version throughout the
Dashboard UX — NOC health cards, sidebar server list, right-click
context menus, Manage Servers, and a new "Check for Updates" button
in the Edit Server dialog. Pin dialog buttons outside the scroll area
so they remain visible during long install/upgrade operations.

Fixes #772

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit 5fcc598 into dev Apr 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant