fix(usbh_modem): accept roaming registration status#714
Open
Talha-Babar wants to merge 1 commit into
Open
Conversation
|
|
Talha-Babar
force-pushed
the
fix/usbh-modem-cereg-roaming
branch
from
d954a31 to
857a46b
Compare
Author
|
Rebased onto latest master, conflict resolved. PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The USB modem stack only accepted stat == 1 (home) as a valid
network registration status in STAGE_START_PPP. Devices registered
as stat == 5 (roaming) per 3GPP TS 27.007 were rejected, causing
"Modem network registration not ready!" and PPP never coming up.
Fix
Accept both stat == 1 (home) and stat == 5 (roaming) in the
registration check in usbh_modem.c.
Note
The release_versions pre-commit hook fails on Windows with a
UnicodeDecodeError (cp1252 can't decode README.md). This is
unrelated to this fix. Suggested fix: open README with encoding="utf-8".